[PR #1286] [MERGED] fix: ensure all post steps are executed #1874

New issue

Closed

opened 2026-03-01 21:53:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1286
Author: @KnisterPeter
Created: 7/29/2022
Status: ✅ Merged
Merged: 7/29/2022
Merged by: @mergify[bot]

Base: master ← Head: ensure-post-steps-are-running

📝 Commits (1)

b489380 fix: ensure all post steps are executed

📊 Changes

7 files changed (+34 additions, -2 deletions)

View changed files

📝 pkg/runner/action_composite.go (+1 -2)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/ensure-post-steps/action-composite/action.yml (+10 -0)
➕ pkg/runner/testdata/ensure-post-steps/action-post/action.yml (+11 -0)
➕ pkg/runner/testdata/ensure-post-steps/action-post/main.js (+0 -0)
➕ pkg/runner/testdata/ensure-post-steps/action-post/post.js (+3 -0)
➕ pkg/runner/testdata/ensure-post-steps/push.yml (+8 -0)

📄 Description

This fixes an issue in the chain of post steps introduced
while updating the step-logger for composite actions.

It includes a test case so we make sure this does not happen
again.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1286 **Author:** [@KnisterPeter](https://github.com/KnisterPeter) **Created:** 7/29/2022 **Status:** ✅ Merged **Merged:** 7/29/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `ensure-post-steps-are-running` --- ### 📝 Commits (1) - [`b489380`](https://github.com/nektos/act/commit/b489380cf0d054f7a5a39f6cd89b9f9845405094) fix: ensure all post steps are executed ### 📊 Changes **7 files changed** (+34 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/action_composite.go` (+1 -2) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/ensure-post-steps/action-composite/action.yml` (+10 -0) ➕ `pkg/runner/testdata/ensure-post-steps/action-post/action.yml` (+11 -0) ➕ `pkg/runner/testdata/ensure-post-steps/action-post/main.js` (+0 -0) ➕ `pkg/runner/testdata/ensure-post-steps/action-post/post.js` (+3 -0) ➕ `pkg/runner/testdata/ensure-post-steps/push.yml` (+8 -0) </details> ### 📄 Description This fixes an issue in the chain of post steps introduced while updating the step-logger for composite actions. It includes a test case so we make sure this does not happen again. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:03 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1874

No description provided.

Rows
Columns