[PR #1247] [MERGED] fix: allow TimeoutMinutes to be expression in Jobs #1858

New issue

Closed

opened 2026-03-01 21:52:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1247
Author: @hishamhm
Created: 7/7/2022
Status: ✅ Merged
Merged: 7/8/2022
Merged by: @mergify[bot]

Base: master ← Head: accept-expr-in-timeout-minutes

📝 Commits (2)

f57facc fix: allow TimeoutMinutes to be expression in Jobs
040034e Merge branch 'master' into accept-expr-in-timeout-minutes

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 pkg/model/workflow.go (+1 -1)

📄 Description

This change stops act from rejecting valid entries such as

    timeout-minutes: ${{ matrix.runtime == 'v8' && 30 || 15 }}

at the jobs: level.

This change complements the fix that was already in place for the Step struct, done by @catthehacker in #1217. See: github.com/nektos/act@52f5c4592c

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1247 **Author:** [@hishamhm](https://github.com/hishamhm) **Created:** 7/7/2022 **Status:** ✅ Merged **Merged:** 7/8/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `accept-expr-in-timeout-minutes` --- ### 📝 Commits (2) - [`f57facc`](https://github.com/nektos/act/commit/f57faccd7771f68b3f5977101027507e1badeded) fix: allow TimeoutMinutes to be expression in Jobs - [`040034e`](https://github.com/nektos/act/commit/040034e1f9e9ad5ac881b8d893acaf87a14454ff) Merge branch 'master' into accept-expr-in-timeout-minutes ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/workflow.go` (+1 -1) </details> ### 📄 Description This change stops act from rejecting valid entries such as ``` timeout-minutes: ${{ matrix.runtime == 'v8' && 30 || 15 }} ``` at the `jobs:` level. This change complements the fix that was already in place for the Step struct, done by @catthehacker in #1217. See: https://github.com/nektos/act/commit/52f5c4592cbbf2e4dde3b35ad42f4e7475ad52df --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:59 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:15 +03:00

[PR #1858] [MERGED] build(deps): bump github.com/moby/buildkit from 0.11.5 to 0.11.6 #2160

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1858

No description provided.

Rows
Columns