[PR #1203] [MERGED] fix: Remove volume with same name as the container again #1836

New issue

Closed

opened 2026-03-01 21:52:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1203
Author: @ChristopherHX
Created: 6/6/2022
Status: ✅ Merged
Merged: 6/7/2022
Merged by: @mergify[bot]

Base: master ← Head: ChristopherHX-remove-both-volumes

📝 Commits (2)

ded5a53 Update run_context.go
da0e658 .

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 pkg/runner/run_context.go (+1 -0)

📄 Description

I reread this function github.com/nektos/act@859445fb94/pkg/runner/run_context.go (L79-L124), then I come to the conclusion that I made a silly mistake in #1148 that both volumes ( name, name+"-env" ) have to be removed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1203 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 6/6/2022 **Status:** ✅ Merged **Merged:** 6/7/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `ChristopherHX-remove-both-volumes` --- ### 📝 Commits (2) - [`ded5a53`](https://github.com/nektos/act/commit/ded5a5316de28aabca5be56f8b137aa1093ea7f1) Update run_context.go - [`da0e658`](https://github.com/nektos/act/commit/da0e658b9749f79e3308da996c4bc7e30aee1f90) . ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+1 -0) </details> ### 📄 Description I reread this function https://github.com/nektos/act/blob/859445fb94e12cc600e5a59d9c9cd687214cb801/pkg/runner/run_context.go#L79-L124, then I come to the conclusion that I made a silly mistake in #1148 that both volumes ( name, name+"-env" ) have to be removed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1836

No description provided.

Rows
Columns