[PR #1145] [MERGED] fix: panic if a step in a job is nil #1803

Closed
opened 2026-03-01 21:52:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1145
Author: @ChristopherHX
Created: 4/29/2022
Status: Merged
Merged: 5/12/2022
Merged by: @mergify[bot]

Base: masterHead: fix-panic-nil-step


📝 Commits (5)

📊 Changes

3 files changed (+13 additions, -0 deletions)

View changed files

📝 pkg/runner/job_executor.go (+5 -0)
📝 pkg/runner/job_executor_test.go (+1 -0)
pkg/runner/testdata/job-nil-step/push.yml (+7 -0)

📄 Description

We need to be careful
Closes #1144

on: push
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
    -
    - run: exit 0
go run . -W .\w.yml -P ubuntu-latest=ubuntu:latest --no-skip-checkout
Error: invalid Step 0: missing run or uses key
exit status 1

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1145 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 4/29/2022 **Status:** ✅ Merged **Merged:** 5/12/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-panic-nil-step` --- ### 📝 Commits (5) - [`7a5160f`](https://github.com/nektos/act/commit/7a5160ff16253c855ceb41729a549c44cc1141eb) fix: panic if a step is a job is nil - [`9d1c11f`](https://github.com/nektos/act/commit/9d1c11fba888d83f97b69b34b315b93973dccde0) simplify - [`aa7be68`](https://github.com/nektos/act/commit/aa7be68b3994dd4ba75a20d4898b168a4d830f6a) [no ci] Add testdata - [`14e7a8d`](https://github.com/nektos/act/commit/14e7a8d736a755807d2da67d28472079c1bfa916) [no ci] Add Test - [`fc892da`](https://github.com/nektos/act/commit/fc892da80d9ce616340eb0391eee730fd310c243) Merge branch 'master' into fix-panic-nil-step ### 📊 Changes **3 files changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/job_executor.go` (+5 -0) 📝 `pkg/runner/job_executor_test.go` (+1 -0) ➕ `pkg/runner/testdata/job-nil-step/push.yml` (+7 -0) </details> ### 📄 Description __We need to be careful__ Closes #1144 ```yaml on: push jobs: test: runs-on: ubuntu-latest steps: - - run: exit 0 ``` ``` go run . -W .\w.yml -P ubuntu-latest=ubuntu:latest --no-skip-checkout Error: invalid Step 0: missing run or uses key exit status 1 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:52:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1803
No description provided.