mirror of
https://github.com/nektos/act.git
synced 2026-04-26 09:25:54 +03:00
[PR #1141] [MERGED] fix: panic while running DRYRUN with local actions #1801
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1801
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/1141
Author: @ChristopherHX
Created: 4/27/2022
Status: ✅ Merged
Merged: 5/11/2022
Merged by: @mergify[bot]
Base:
master← Head:fix-panic-localaction-dryrun📝 Commits (2)
38538abfix: panic while running DRYRUN with local actionsd3b83e1Merge branch 'master' into fix-panic-localaction-dryrun📊 Changes
1 file changed (+3 additions, -0 deletions)
View changed files
📝
pkg/container/docker_run.go(+3 -0)📄 Description
With this change act's dryrun no longer panics after my previous change #719. An error is better than a panic.
We need to consider how act can support dryrun for localactions.
Closes #1140
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.