[PR #1141] [MERGED] fix: panic while running DRYRUN with local actions #1801

Closed
opened 2026-03-01 21:52:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1141
Author: @ChristopherHX
Created: 4/27/2022
Status: Merged
Merged: 5/11/2022
Merged by: @mergify[bot]

Base: masterHead: fix-panic-localaction-dryrun


📝 Commits (2)

  • 38538ab fix: panic while running DRYRUN with local actions
  • d3b83e1 Merge branch 'master' into fix-panic-localaction-dryrun

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 pkg/container/docker_run.go (+3 -0)

📄 Description

With this change act's dryrun no longer panics after my previous change #719. An error is better than a panic.

We need to consider how act can support dryrun for localactions.

Closes #1140


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1141 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 4/27/2022 **Status:** ✅ Merged **Merged:** 5/11/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-panic-localaction-dryrun` --- ### 📝 Commits (2) - [`38538ab`](https://github.com/nektos/act/commit/38538ab3107c07f71a8ad0da5d7fc8916d5584f8) fix: panic while running DRYRUN with local actions - [`d3b83e1`](https://github.com/nektos/act/commit/d3b83e118fa966f2067c8ce793b0f956e2cc0e6a) Merge branch 'master' into fix-panic-localaction-dryrun ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+3 -0) </details> ### 📄 Description With this change act's dryrun no longer panics after my previous change #719. An error is better than a panic. We need to consider how act can support dryrun for localactions. Closes #1140 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:52:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1801
No description provided.