[PR #1137] [MERGED] fix: expression evaluator do not error that much #1799

New issue

Closed

opened 2026-03-01 21:52:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1137
Author: @ChristopherHX
Created: 4/20/2022
Status: ✅ Merged
Merged: 4/26/2022
Merged by: @mergify[bot]

Base: master ← Head: exprevalfixes2

📝 Commits (2)

b31377f fix: do not error that much
17b16dc Merge branch 'master' into exprevalfixes2

📊 Changes

2 files changed (+11 additions, -4 deletions)

View changed files

📝 pkg/exprparser/interpreter.go (+3 -3)
📝 pkg/exprparser/interpreter_test.go (+8 -1)

📄 Description

Why does the new expression evaluator returns far more errors than the original?
I can't get fromJSON('[0,1]')['1.1'] to work, it doesn't return null.

Closes #1071
Closes #1115

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1137 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 4/20/2022 **Status:** ✅ Merged **Merged:** 4/26/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `exprevalfixes2` --- ### 📝 Commits (2) - [`b31377f`](https://github.com/nektos/act/commit/b31377ffaaa5f05df5f6fcf6a8c2e54d082d278d) fix: do not error that much - [`17b16dc`](https://github.com/nektos/act/commit/17b16dc1f564612cf22bcf037fd92666c888ceff) Merge branch 'master' into exprevalfixes2 ### 📊 Changes **2 files changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/exprparser/interpreter.go` (+3 -3) 📝 `pkg/exprparser/interpreter_test.go` (+8 -1) </details> ### 📄 Description Why does the new expression evaluator returns far more errors than the original? I can't get `fromJSON('[0,1]')['1.1']` to work, it doesn't return null. Closes #1071 Closes #1115 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1799

No description provided.

Rows
Columns