[PR #1136] [MERGED] fix: conclusion and outcome are no integers #1798

New issue

Closed

opened 2026-03-01 21:52:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1136
Author: @ChristopherHX
Created: 4/20/2022
Status: ✅ Merged
Merged: 4/26/2022
Merged by: @mergify[bot]

Base: master ← Head: exprevalfixes

📝 Commits (3)

af2f616 fix: conclusion and outcome are no integers
d9dde19 Change Test
909f2fc Merge branch 'master' into exprevalfixes

📊 Changes

3 files changed (+37 additions, -7 deletions)

View changed files

📝 pkg/exprparser/interpreter.go (+11 -1)
📝 pkg/exprparser/interpreter_test.go (+20 -0)
📝 pkg/runner/expression_test.go (+6 -6)

📄 Description

Closes #1109

If I'm not mistaken there might be still some cases which are invalid for the stepStatus structure.

I'm a bit confused how the expression evaluator is working:
I can't get contains(steps.*.outputs.name, 'value') working.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1136 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 4/20/2022 **Status:** ✅ Merged **Merged:** 4/26/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `exprevalfixes` --- ### 📝 Commits (3) - [`af2f616`](https://github.com/nektos/act/commit/af2f616fd1b520d1c2c9f0db7ed9a75626b946ae) fix: conclusion and outcome are no integers - [`d9dde19`](https://github.com/nektos/act/commit/d9dde196ba6aecffd98850f86c8f14ade01836c2) Change Test - [`909f2fc`](https://github.com/nektos/act/commit/909f2fcdf2cea8ca927130fa709a448106792baa) Merge branch 'master' into exprevalfixes ### 📊 Changes **3 files changed** (+37 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkg/exprparser/interpreter.go` (+11 -1) 📝 `pkg/exprparser/interpreter_test.go` (+20 -0) 📝 `pkg/runner/expression_test.go` (+6 -6) </details> ### 📄 Description Closes #1109 If I'm not mistaken there might be still some cases which are invalid for the stepStatus structure. I'm a bit confused how the expression evaluator is working: I can't get `contains(steps.*.outputs.name, 'value')` working. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1798

No description provided.

Rows
Columns