[PR #1103] [CLOSED] wip: #1777

Closed
opened 2026-03-01 21:52:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1103
Author: @catthehacker
Created: 4/4/2022
Status: Closed

Base: masterHead: cat/feat/better-logging


📝 Commits (1)

📊 Changes

58 files changed (+844 additions, -752 deletions)

View changed files

📝 cmd/graph.go (+4 -4)
📝 cmd/root.go (+25 -15)
📝 pkg/artifacts/server.go (+3 -2)
📝 pkg/artifacts/server_test.go (+5 -3)
📝 pkg/common/dryrun/dryrun.go (+1 -1)
📝 pkg/common/executor/executor.go (+14 -3)
📝 pkg/common/executor/executor_test.go (+1 -1)
📝 pkg/common/git/git.go (+23 -20)
📝 pkg/common/git/git_test.go (+1 -1)
pkg/common/logger.go (+0 -27)
pkg/common/logger/logger.go (+185 -0)
📝 pkg/common/utils/draw.go (+1 -1)
📝 pkg/common/utils/file.go (+1 -1)
📝 pkg/common/utils/outbound_ip.go (+2 -2)
pkg/common/utils/term.go (+51 -0)
📝 pkg/container/docker_auth.go (+1 -0)
📝 pkg/container/docker_build.go (+10 -9)
📝 pkg/container/docker_images_test.go (+1 -0)
📝 pkg/container/docker_logger.go (+4 -57)
📝 pkg/container/docker_pull.go (+9 -7)

...and 38 more files

📄 Description

Fixes #195

  • add --no-color flag
  • handle more envvars for colour disabling
  • Unicode Emojis are disabled for terminals not capable of colours and/or envvars/flag
  • Moved logger from runner to common
  • add check for survey to verify that terminal is capable of answering it
  • moved github.com/nektos/act/pkg/runner.Config to github.com/nektos/act/pkg/runner/config.Config
  • change --verbose from bool to count, single --verbose enables Debug log level, 2 or more enable Trace log level
    • logrus.FieldLogger was replaced with logrus.Ext1FieldLogger since logrus.FieldLogger does not export Trace log level functions

Signed-off-by: hackercat me@hackerc.at


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1103 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 4/4/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cat/feat/better-logging` --- ### 📝 Commits (1) - [`667f07b`](https://github.com/nektos/act/commit/667f07ba057d0b59d30122c945bd6affee92ba2f) wip: ### 📊 Changes **58 files changed** (+844 additions, -752 deletions) <details> <summary>View changed files</summary> 📝 `cmd/graph.go` (+4 -4) 📝 `cmd/root.go` (+25 -15) 📝 `pkg/artifacts/server.go` (+3 -2) 📝 `pkg/artifacts/server_test.go` (+5 -3) 📝 `pkg/common/dryrun/dryrun.go` (+1 -1) 📝 `pkg/common/executor/executor.go` (+14 -3) 📝 `pkg/common/executor/executor_test.go` (+1 -1) 📝 `pkg/common/git/git.go` (+23 -20) 📝 `pkg/common/git/git_test.go` (+1 -1) ➖ `pkg/common/logger.go` (+0 -27) ➕ `pkg/common/logger/logger.go` (+185 -0) 📝 `pkg/common/utils/draw.go` (+1 -1) 📝 `pkg/common/utils/file.go` (+1 -1) 📝 `pkg/common/utils/outbound_ip.go` (+2 -2) ➕ `pkg/common/utils/term.go` (+51 -0) 📝 `pkg/container/docker_auth.go` (+1 -0) 📝 `pkg/container/docker_build.go` (+10 -9) 📝 `pkg/container/docker_images_test.go` (+1 -0) 📝 `pkg/container/docker_logger.go` (+4 -57) 📝 `pkg/container/docker_pull.go` (+9 -7) _...and 38 more files_ </details> ### 📄 Description Fixes #195 - add `--no-color` flag - handle more envvars for colour disabling - Unicode Emojis are disabled for terminals not capable of colours and/or envvars/flag - Moved logger from `runner` to `common` - add check for survey to verify that terminal is capable of answering it - moved `github.com/nektos/act/pkg/runner.Config` to `github.com/nektos/act/pkg/runner/config.Config` - change `--verbose` from `bool` to `count`, single `--verbose` enables `Debug` log level, 2 or more enable `Trace` log level - `logrus.FieldLogger` was replaced with `logrus.Ext1FieldLogger` since `logrus.FieldLogger` does not export `Trace` log level functions Signed-off-by: hackercat <me@hackerc.at> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:52:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1777
No description provided.