errors dependency #1760

New issue

Closed

opened 2026-03-01 21:52:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1077
Author: @catthehacker
Created: 3/25/2022
Status: ✅ Merged
Merged: 6/10/2022
Merged by: @mergify[bot]

Base: master ← Head: refactor/remove-ext-errors-dep

📝 Commits (7)

e9b86f1 refactor: split out common/git
577a354 refactor: move git options to separate func
a7795b8 refactor: remove github.com/pkg/errors dependency
8f668f3 fix(golangci-lint): forbid github.com/pkg/errors
781875c style: fix typo
85ad8cd style: fix typo
9811efb Merge branch 'master' into refactor/remove-ext-errors-dep

📊 Changes

13 files changed (+133 additions, -97 deletions)

View changed files

📝 .golangci.yml (+3 -1)
📝 go.mod (+1 -1)
📝 pkg/common/git/git.go (+50 -27)
📝 pkg/common/git/git_test.go (+11 -9)
📝 pkg/container/docker_pull.go (+2 -2)
📝 pkg/container/docker_run.go (+34 -28)
📝 pkg/container/file_collector.go (+1 -2)
📝 pkg/model/github_context.go (+4 -3)
📝 pkg/model/planner.go (+5 -6)
📝 pkg/model/planner_test.go (+2 -2)
📝 pkg/runner/run_context.go (+4 -5)
📝 pkg/runner/step_action_remote.go (+12 -9)
📝 pkg/runner/step_action_remote_test.go (+4 -2)

📄 Description

moved git from common in it's own package
improved error messages
Container.Close() returns an error if closing the docker socket fails
Container.Exec() returns a decriptive error for 127 file not found

Originally posted by @ChristopherHX in https://github.com/nektos/act/pull/1077#pullrequestreview-962491683

forbid github.com/pkg/errors via golangci-lint

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1077 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 3/25/2022 **Status:** ✅ Merged **Merged:** 6/10/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `refactor/remove-ext-errors-dep` --- ### 📝 Commits (7) - [`e9b86f1`](https://github.com/nektos/act/commit/e9b86f1361bb9502dca3a9f3b23b441fe8dedd00) refactor: split out common/git - [`577a354`](https://github.com/nektos/act/commit/577a35443f2dfbbc4d7f6e0f5e4a915910c97021) refactor: move git options to separate func - [`a7795b8`](https://github.com/nektos/act/commit/a7795b80fe1860eeb95b8e9ef7d92e340207066f) refactor: remove github.com/pkg/errors dependency - [`8f668f3`](https://github.com/nektos/act/commit/8f668f3be3bcff5c79c717f43f177522df36f779) fix(golangci-lint): forbid github.com/pkg/errors - [`781875c`](https://github.com/nektos/act/commit/781875c3aff0ced72d5eba04459f0a81f415a879) style: fix typo - [`85ad8cd`](https://github.com/nektos/act/commit/85ad8cdcb20cdc37dc4e11229f97695f8dbb8a29) style: fix typo - [`9811efb`](https://github.com/nektos/act/commit/9811efb818acaef3e498115f34c7e29201766e0a) Merge branch 'master' into refactor/remove-ext-errors-dep ### 📊 Changes **13 files changed** (+133 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `.golangci.yml` (+3 -1) 📝 `go.mod` (+1 -1) 📝 `pkg/common/git/git.go` (+50 -27) 📝 `pkg/common/git/git_test.go` (+11 -9) 📝 `pkg/container/docker_pull.go` (+2 -2) 📝 `pkg/container/docker_run.go` (+34 -28) 📝 `pkg/container/file_collector.go` (+1 -2) 📝 `pkg/model/github_context.go` (+4 -3) 📝 `pkg/model/planner.go` (+5 -6) 📝 `pkg/model/planner_test.go` (+2 -2) 📝 `pkg/runner/run_context.go` (+4 -5) 📝 `pkg/runner/step_action_remote.go` (+12 -9) 📝 `pkg/runner/step_action_remote_test.go` (+4 -2) </details> ### 📄 Description - moved git from common in it's own package - improved error messages - Container.Close() returns an error if closing the docker socket fails - Container.Exec() returns a decriptive error for 127 file not found _Originally posted by @ChristopherHX in https://github.com/nektos/act/pull/1077#pullrequestreview-962491683_ - forbid `github.com/pkg/errors` via `golangci-lint` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:33 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:04 +03:00

[PR #1760] [CLOSED] Don't bind host docker daemon socket #2115

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1760

No description provided.

Rows
Columns