[PR #1041] [MERGED] Revert: Don't stop JobContainer on failure #1745

New issue

Closed

opened 2026-03-01 21:52:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1041
Author: @ChristopherHX
Created: 3/14/2022
Status: ✅ Merged
Merged: 3/14/2022
Merged by: @mergify[bot]

Base: master ← Head: revert/remove-jobcontainer-on-failure

📝 Commits (1)

a5f45a3 Revert: Don't stop JobContainer on failure

📊 Changes

2 files changed (+4 additions, -6 deletions)

View changed files

📝 pkg/runner/job_executor.go (+4 -5)
📝 pkg/runner/job_executor_test.go (+0 -1)

📄 Description

This was a breaking change of nektos/act#840

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1041 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 3/14/2022 **Status:** ✅ Merged **Merged:** 3/14/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `revert/remove-jobcontainer-on-failure` --- ### 📝 Commits (1) - [`a5f45a3`](https://github.com/nektos/act/commit/a5f45a3ccd102856d215ba61b4c3613be737c90f) Revert: Don't stop JobContainer on failure ### 📊 Changes **2 files changed** (+4 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/job_executor.go` (+4 -5) 📝 `pkg/runner/job_executor_test.go` (+0 -1) </details> ### 📄 Description This was a breaking change of [nektos/act#840](https://github.com/nektos/act/pull/840) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:30 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:02 +03:00

[PR #1745] [MERGED] fix: try finding a socket, otherwise fail, respect user choice #2106

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1745

No description provided.

Rows
Columns