[PR #988] [MERGED] fix: always execute closeContainer() executor #1715

New issue

Closed

opened 2026-03-01 21:52:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/988
Author: @ZauberNerd
Created: 2/9/2022
Status: ✅ Merged
Merged: 2/10/2022
Merged by: @mergify[bot]

Base: master ← Head: fix-jobexecutor-refactoring

📝 Commits (2)

98cbcd4 fix: always execute closeContainer() executor
5bba913 test: add testcases to ensure job containers are started/stopped

📊 Changes

2 files changed (+72 additions, -26 deletions)

View changed files

📝 pkg/runner/job_executor.go (+2 -4)
📝 pkg/runner/job_executor_test.go (+70 -22)

📄 Description

During our earlier refactoring in https://github.com/nektos/act/pull/984 we accidentally changed the
behaviour in such a way that the closeContainer() executor was never
called.

This commit restores the earlier behaviour and adds test cases for this regression.

Ref:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/988 **Author:** [@ZauberNerd](https://github.com/ZauberNerd) **Created:** 2/9/2022 **Status:** ✅ Merged **Merged:** 2/10/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-jobexecutor-refactoring` --- ### 📝 Commits (2) - [`98cbcd4`](https://github.com/nektos/act/commit/98cbcd465b405d38b80840c9e85cb9e53fca4bb0) fix: always execute closeContainer() executor - [`5bba913`](https://github.com/nektos/act/commit/5bba91351109578acccadbd097ec5682c2e258f4) test: add testcases to ensure job containers are started/stopped ### 📊 Changes **2 files changed** (+72 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/job_executor.go` (+2 -4) 📝 `pkg/runner/job_executor_test.go` (+70 -22) </details> ### 📄 Description During our earlier refactoring in https://github.com/nektos/act/pull/984 we accidentally changed the behaviour in such a way that the `closeContainer()` executor was never called. This commit restores the earlier behaviour and adds test cases for this regression. Ref: * https://github.com/nektos/act/pull/984/files#diff-c057d66dc9657d8428e290c69871596e2b567bb8fecad62a99cab54398131a84L294 * https://github.com/nektos/act/pull/984/files#diff-ea9d5c93d769ef9b268932dd9990363e97fc3bec8a00114979d049bead5dd718R68 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:22 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1715

No description provided.

Rows
Columns