[PR #984] [MERGED] refactor: extract RunContext Executor in JobExecutor #1714

New issue

Closed

opened 2026-03-01 21:52:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/984
Author: @Poltergeist
Created: 2/8/2022
Status: ✅ Merged
Merged: 2/8/2022
Merged by: @mergify[bot]

Base: master ← Head: refactor/runcontext

📝 Commits (1)

2379855 refactor: extract RunContext Executor in JobExecutor

📊 Changes

4 files changed (+232 additions, -44 deletions)

View changed files

📝 go.sum (+1 -0)
➕ pkg/runner/job_executor.go (+71 -0)
➕ pkg/runner/job_executor_test.go (+135 -0)
📝 pkg/runner/run_context.go (+25 -44)

📄 Description

This splits the executor from the RunContext into its own function
called newJobExecutor.
We defined an interface called jobInfo which is implemented by the RunContext.
This enables better unit testing because only a small interface needs to
be mocked.

This is a preparation for implementing pre and post actions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/984 **Author:** [@Poltergeist](https://github.com/Poltergeist) **Created:** 2/8/2022 **Status:** ✅ Merged **Merged:** 2/8/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `refactor/runcontext` --- ### 📝 Commits (1) - [`2379855`](https://github.com/nektos/act/commit/23798557a8824d4fa31e5a3e64a244ee0fc28fb9) refactor: extract RunContext Executor in JobExecutor ### 📊 Changes **4 files changed** (+232 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `go.sum` (+1 -0) ➕ `pkg/runner/job_executor.go` (+71 -0) ➕ `pkg/runner/job_executor_test.go` (+135 -0) 📝 `pkg/runner/run_context.go` (+25 -44) </details> ### 📄 Description This splits the executor from the `RunContext` into its own function called `newJobExecutor`. We defined an interface called `jobInfo` which is implemented by the `RunContext`. This enables better unit testing because only a small interface needs to be mocked. This is a preparation for implementing pre and post actions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:22 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1714

No description provided.

Rows
Columns