[PR #986] [MERGED] refactor: extract setupAction into ActionReader #1713

Closed
opened 2026-03-01 21:52:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/986
Author: @ZauberNerd
Created: 2/8/2022
Status: Merged
Merged: 2/8/2022
Merged by: @mergify[bot]

Base: masterHead: refactor/setup-action


📝 Commits (1)

  • a9d0666 refactor: extract setupAction into ActionReader

📊 Changes

3 files changed (+246 additions, -85 deletions)

View changed files

pkg/runner/action.go (+84 -0)
pkg/runner/action_test.go (+133 -0)
📝 pkg/runner/step_context.go (+29 -85)

📄 Description

This change extracts the functionality of reading an action.y(a)ml or
creation of a (Synthetic Action) into its own type to enable better
unit testing / mocking of those IO operations.

This is done in preparation for the implementation of pre/post action
support in act.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/986 **Author:** [@ZauberNerd](https://github.com/ZauberNerd) **Created:** 2/8/2022 **Status:** ✅ Merged **Merged:** 2/8/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `refactor/setup-action` --- ### 📝 Commits (1) - [`a9d0666`](https://github.com/nektos/act/commit/a9d0666862096fba150c5acdabfc9e61d8811453) refactor: extract setupAction into ActionReader ### 📊 Changes **3 files changed** (+246 additions, -85 deletions) <details> <summary>View changed files</summary> ➕ `pkg/runner/action.go` (+84 -0) ➕ `pkg/runner/action_test.go` (+133 -0) 📝 `pkg/runner/step_context.go` (+29 -85) </details> ### 📄 Description This change extracts the functionality of reading an `action.y(a)ml` or creation of a `(Synthetic Action)` into its own type to enable better unit testing / mocking of those IO operations. This is done in preparation for the implementation of pre/post action support in act. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:52:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1713
No description provided.