[PR #971] [MERGED] Fix: regression run after failure #1709

New issue

Closed

opened 2026-03-01 21:52:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/971
Author: @ChristopherHX
Created: 1/27/2022
Status: ✅ Merged
Merged: 1/27/2022
Merged by: @mergify[bot]

Base: master ← Head: fix/regression-run-after-failure

📝 Commits (3)

addb730 Fix: Regressions of run step after failure
446864f Add test, to enshure no panic
67dbd23 Print error of failed step

📊 Changes

4 files changed (+37 additions, -6 deletions)

View changed files

📝 pkg/common/executor.go (+5 -4)
📝 pkg/runner/run_context.go (+24 -2)
📝 pkg/runner/runner_test.go (+1 -0)
➕ pkg/runner/testdata/non-existent-action/push.yml (+7 -0)

📄 Description

Restore the old behavior of the then executor. A lot of code in act relies on the fact that the pipeline executor fails fast instead of failing later.

Here a list of regressions

https://github.com/nektos/act/issues/946 failing to read an action => panic
returning an error at this line https://github.com/nektos/act/pull/964/commits/f538b28a53f03e082feca382f18b1cdea0192d0c#diff-3ca8bf2cdff0ec928622b093c6af8793a24f0f5f9a397c86e1df94a385be6e44R130 => panic
failed to connect to docker => panic
no cleanup on panic, the finally executor doesn't run
This broke error handling of act. I prefer to revert this function to it's previous version and create a new finally executor to archive the same in a less error prone.

Also print the error of the step, since it is useful to know why my action failed. E.g. if you used continue-on-error in a composite action.

Resolves https://github.com/nektos/act/issues/946

@KnisterPeter @ZauberNerd You introduced the regression in github.com/nektos/act@1891c72ab1

The observation of the edit of this comment https://github.com/nektos/act/pull/948#issuecomment-1022949930 is caused by the same regression, job failure without reason.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/971 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 1/27/2022 **Status:** ✅ Merged **Merged:** 1/27/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix/regression-run-after-failure` --- ### 📝 Commits (3) - [`addb730`](https://github.com/nektos/act/commit/addb730fb9790bec71fbf9de984fae4c0b617255) Fix: Regressions of run step after failure - [`446864f`](https://github.com/nektos/act/commit/446864f677465b16035aad1462a60d9d8583a2b0) Add test, to enshure no panic - [`67dbd23`](https://github.com/nektos/act/commit/67dbd23b0359d7bf186c6c36fa63d43dcc1ba62b) Print error of failed step ### 📊 Changes **4 files changed** (+37 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkg/common/executor.go` (+5 -4) 📝 `pkg/runner/run_context.go` (+24 -2) 📝 `pkg/runner/runner_test.go` (+1 -0) ➕ `pkg/runner/testdata/non-existent-action/push.yml` (+7 -0) </details> ### 📄 Description Restore the old behavior of the then executor. A lot of code in act relies on the fact that the pipeline executor fails fast instead of failing later. Here a list of regressions - https://github.com/nektos/act/issues/946 failing to read an action => panic - returning an error at this line https://github.com/nektos/act/pull/964/commits/f538b28a53f03e082feca382f18b1cdea0192d0c#diff-3ca8bf2cdff0ec928622b093c6af8793a24f0f5f9a397c86e1df94a385be6e44R130 => panic - failed to connect to docker => panic - no cleanup on panic, the finally executor doesn't run This broke error handling of act. I prefer to revert this function to it's previous version and create a new finally executor to archive the same in a less error prone. Also print the error of the step, since it is useful to know why my action failed. E.g. if you used continue-on-error in a composite action. Resolves https://github.com/nektos/act/issues/946 @KnisterPeter @ZauberNerd You introduced the regression in https://github.com/nektos/act/commit/1891c72ab158508e36009d16b24913fa5836422b The observation of the edit of this comment https://github.com/nektos/act/pull/948#issuecomment-1022949930 is caused by the same regression, job failure without reason. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:20 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:56 +03:00

[PR #1709] [CLOSED] feature: reference workflowpattern package to add workflow filtering #2085

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1709

No description provided.

Rows
Columns