[PR #945] [MERGED] fix: set composite outputs on failure #1697

New issue

Closed

opened 2026-03-01 21:52:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/945
Author: @ChristopherHX
Created: 12/30/2021
Status: ✅ Merged
Merged: 1/21/2022
Merged by: @cplee

Base: master ← Head: fix/composite-outputs-on-failure

📝 Commits (1)

a06d53e fix: set composite outputs on failure

📊 Changes

5 files changed (+32 additions, -5 deletions)

View changed files

📝 pkg/runner/run_context.go (+3 -1)
📝 pkg/runner/runner_test.go (+1 -0)
📝 pkg/runner/step_context.go (+1 -4)
➕ pkg/runner/testdata/actions/composite-fail-with-output/action.yml (+13 -0)
➕ pkg/runner/testdata/composite-fail-with-output/push.yml (+14 -0)

📄 Description

fix: conclusion and outcome after error with failure condition
fix: continue-on-error doesn't work correctly for composite actions

I added a test workflow for this defect.

Follow up of https://github.com/nektos/act/pull/793

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/945 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 12/30/2021 **Status:** ✅ Merged **Merged:** 1/21/2022 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `fix/composite-outputs-on-failure` --- ### 📝 Commits (1) - [`a06d53e`](https://github.com/nektos/act/commit/a06d53ebd4dc25756a4728e5a33bee387a32b98f) fix: set composite outputs on failure ### 📊 Changes **5 files changed** (+32 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+3 -1) 📝 `pkg/runner/runner_test.go` (+1 -0) 📝 `pkg/runner/step_context.go` (+1 -4) ➕ `pkg/runner/testdata/actions/composite-fail-with-output/action.yml` (+13 -0) ➕ `pkg/runner/testdata/composite-fail-with-output/push.yml` (+14 -0) </details> ### 📄 Description fix: conclusion and outcome after error with failure condition fix: continue-on-error doesn't work correctly for composite actions I added a test workflow for this defect. Follow up of https://github.com/nektos/act/pull/793 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:16 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1697

No description provided.

Rows
Columns