mirror of
https://github.com/nektos/act.git
synced 2026-04-26 09:25:54 +03:00
[PR #931] [MERGED] refactor: export and move shared contexts into pkg/model #1689
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1689
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/931
Author: @ZauberNerd
Created: 12/16/2021
Status: ✅ Merged
Merged: 12/22/2021
Merged by: @mergify[bot]
Base:
master← Head:move-shared-contexts📝 Commits (2)
6efaf9frefactor: export and move shared contexts into pkg/modelb94b333Merge branch 'master' into move-shared-contexts📊 Changes
10 files changed (+132 additions, -124 deletions)
View changed files
➕
pkg/model/github_context.go(+28 -0)➕
pkg/model/job_context.go(+12 -0)➕
pkg/model/step_result.go(+43 -0)📝
pkg/runner/command_test.go(+3 -2)📝
pkg/runner/expression_test.go(+9 -7)📝
pkg/runner/run_context.go(+18 -96)📝
pkg/runner/run_context_test.go(+4 -4)📝
pkg/runner/runner.go(+1 -1)📝
pkg/runner/step_context.go(+1 -1)📝
pkg/runner/step_context_test.go(+13 -13)📄 Description
This commit moves the
githubContext,jobContextandstepResultstructsfrom the
runnerpackage to themodelpackage in preparation for #908because the
expression.gofile lives in therunnerpackage and wouldintroduce cyclic dependencies with the
exprparserpackage.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.