[PR #931] [MERGED] refactor: export and move shared contexts into pkg/model #1689

Closed
opened 2026-03-01 21:52:15 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/931
Author: @ZauberNerd
Created: 12/16/2021
Status: Merged
Merged: 12/22/2021
Merged by: @mergify[bot]

Base: masterHead: move-shared-contexts


📝 Commits (2)

  • 6efaf9f refactor: export and move shared contexts into pkg/model
  • b94b333 Merge branch 'master' into move-shared-contexts

📊 Changes

10 files changed (+132 additions, -124 deletions)

View changed files

pkg/model/github_context.go (+28 -0)
pkg/model/job_context.go (+12 -0)
pkg/model/step_result.go (+43 -0)
📝 pkg/runner/command_test.go (+3 -2)
📝 pkg/runner/expression_test.go (+9 -7)
📝 pkg/runner/run_context.go (+18 -96)
📝 pkg/runner/run_context_test.go (+4 -4)
📝 pkg/runner/runner.go (+1 -1)
📝 pkg/runner/step_context.go (+1 -1)
📝 pkg/runner/step_context_test.go (+13 -13)

📄 Description

This commit moves the githubContext, jobContext and stepResult structs
from the runner package to the model package in preparation for #908
because the expression.go file lives in the runner package and would
introduce cyclic dependencies with the exprparser package.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/931 **Author:** [@ZauberNerd](https://github.com/ZauberNerd) **Created:** 12/16/2021 **Status:** ✅ Merged **Merged:** 12/22/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `move-shared-contexts` --- ### 📝 Commits (2) - [`6efaf9f`](https://github.com/nektos/act/commit/6efaf9fba96f541c20dfad2eeaa8e6ef5ea84ca7) refactor: export and move shared contexts into pkg/model - [`b94b333`](https://github.com/nektos/act/commit/b94b3334e8ba418b7da15c535ea75d65ef1859a3) Merge branch 'master' into move-shared-contexts ### 📊 Changes **10 files changed** (+132 additions, -124 deletions) <details> <summary>View changed files</summary> ➕ `pkg/model/github_context.go` (+28 -0) ➕ `pkg/model/job_context.go` (+12 -0) ➕ `pkg/model/step_result.go` (+43 -0) 📝 `pkg/runner/command_test.go` (+3 -2) 📝 `pkg/runner/expression_test.go` (+9 -7) 📝 `pkg/runner/run_context.go` (+18 -96) 📝 `pkg/runner/run_context_test.go` (+4 -4) 📝 `pkg/runner/runner.go` (+1 -1) 📝 `pkg/runner/step_context.go` (+1 -1) 📝 `pkg/runner/step_context_test.go` (+13 -13) </details> ### 📄 Description This commit moves the `githubContext`, `jobContext` and `stepResult` structs from the `runner` package to the `model` package in preparation for #908 because the `expression.go` file lives in the `runner` package and would introduce cyclic dependencies with the `exprparser` package. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:52:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1689
No description provided.