[PR #928] [CLOSED] Refactor logging #1686

New issue

Closed

opened 2026-03-01 21:52:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/928
Author: @catthehacker
Created: 12/15/2021
Status: ❌ Closed

Base: master ← Head: cat/feat/better-logging

📝 Commits (2)

0a766b3 wip:
5beb84c fixup! wip:

📊 Changes

20 files changed (+288 additions, -297 deletions)

View changed files

📝 cmd/root.go (+18 -10)
📝 pkg/common/executor.go (+9 -0)
📝 pkg/common/git.go (+15 -16)
📝 pkg/common/logger.go (+172 -6)
📝 pkg/container/docker_build.go (+2 -2)
📝 pkg/container/docker_logger.go (+4 -57)
📝 pkg/container/docker_pull.go (+1 -1)
📝 pkg/container/docker_run.go (+18 -12)
📝 pkg/container/docker_volume.go (+1 -1)
📝 pkg/model/github_context.go (+1 -1)
📝 pkg/model/planner.go (+5 -5)
📝 pkg/runner/command.go (+12 -11)
📝 pkg/runner/command_test.go (+1 -1)
📝 pkg/runner/expression.go (+1 -1)
➖ pkg/runner/logger.go (+0 -140)
📝 pkg/runner/run_context.go (+7 -7)
📝 pkg/runner/run_context_test.go (+4 -4)
📝 pkg/runner/runner.go (+2 -1)
📝 pkg/runner/runner_test.go (+15 -16)
📝 pkg/runner/step_context_test.go (+0 -5)

📄 Description

Fixes #195

add --no-color flag
handle more envvars for colour disabling
Unicode Emojis are disabled for terminals not capable of colours and/or envvars/flag
Moved logger from runner to common
add check for survey to verify that terminal is capable of answering it
change --verbose from bool to count, single --verbose enables Debug log level, 2 or more enable Trace log level
- logrus.FieldLogger was replaced with logrus.Ext1FieldLogger since logrus.FieldLogger does not export Trace log level functions

Signed-off-by: hackercat me@hackerc.at

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/928 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 12/15/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cat/feat/better-logging` --- ### 📝 Commits (2) - [`0a766b3`](https://github.com/nektos/act/commit/0a766b3233f121d66d252f56a685e152b6c84791) wip: - [`5beb84c`](https://github.com/nektos/act/commit/5beb84c2bf74ce24b235ba22d17ec7a884dd2e20) fixup! wip: ### 📊 Changes **20 files changed** (+288 additions, -297 deletions) <details> <summary>View changed files</summary> 📝 `cmd/root.go` (+18 -10) 📝 `pkg/common/executor.go` (+9 -0) 📝 `pkg/common/git.go` (+15 -16) 📝 `pkg/common/logger.go` (+172 -6) 📝 `pkg/container/docker_build.go` (+2 -2) 📝 `pkg/container/docker_logger.go` (+4 -57) 📝 `pkg/container/docker_pull.go` (+1 -1) 📝 `pkg/container/docker_run.go` (+18 -12) 📝 `pkg/container/docker_volume.go` (+1 -1) 📝 `pkg/model/github_context.go` (+1 -1) 📝 `pkg/model/planner.go` (+5 -5) 📝 `pkg/runner/command.go` (+12 -11) 📝 `pkg/runner/command_test.go` (+1 -1) 📝 `pkg/runner/expression.go` (+1 -1) ➖ `pkg/runner/logger.go` (+0 -140) 📝 `pkg/runner/run_context.go` (+7 -7) 📝 `pkg/runner/run_context_test.go` (+4 -4) 📝 `pkg/runner/runner.go` (+2 -1) 📝 `pkg/runner/runner_test.go` (+15 -16) 📝 `pkg/runner/step_context_test.go` (+0 -5) </details> ### 📄 Description Fixes #195 - add `--no-color` flag - handle more envvars for colour disabling - Unicode Emojis are disabled for terminals not capable of colours and/or envvars/flag - Moved logger from `runner` to `common` - add check for survey to verify that terminal is capable of answering it - change `--verbose` from `bool` to `count`, single `--verbose` enables `Debug` log level, 2 or more enable `Trace` log level - `logrus.FieldLogger` was replaced with `logrus.Ext1FieldLogger` since `logrus.FieldLogger` does not export `Trace` log level functions Signed-off-by: hackercat <me@hackerc.at> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:14 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:53 +03:00

[PR #1686] [MERGED] Make sure working directory is respected when configured from matrix #2070

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1686

No description provided.

Rows
Columns