[PR #922] [MERGED] feat: add node16 support #1684

New issue

Closed

opened 2026-03-01 21:52:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/922
Author: @catthehacker
Created: 12/10/2021
Status: ✅ Merged
Merged: 12/22/2021
Merged by: @mergify[bot]

Base: master ← Head: cat/feat/node16

📝 Commits (7)

7daabd0 feat: add node16 support
80f52a2 feat: bump images to node16
1274576 lint(editorconfig): ignore *.md due to mixed style
3d79b55 Merge branch 'master' into cat/feat/node16
0f4d75e Merge branch 'master' into cat/feat/node16
74684a6 Merge branch 'master' into cat/feat/node16
9428e91 Merge branch 'master' into cat/feat/node16

📊 Changes

27 files changed (+9200 additions, -32 deletions)

View changed files

📝 IMAGES.md (+4 -0)
📝 README.md (+4 -4)
📝 cmd/platforms.go (+3 -3)
📝 cmd/root.go (+1 -1)
📝 pkg/artifacts/server_test.go (+1 -1)
📝 pkg/container/docker_images_test.go (+4 -4)
📝 pkg/model/action.go (+4 -1)
📝 pkg/runner/runner_test.go (+2 -2)
📝 pkg/runner/step_context.go (+2 -1)
📝 pkg/runner/testdata/actions/docker-local/Dockerfile (+1 -1)
📝 pkg/runner/testdata/actions/docker-url/action.yml (+1 -1)
📝 pkg/runner/testdata/actions/node12/package.json (+3 -0)
➕ pkg/runner/testdata/actions/node16/README.md (+3 -0)
➕ pkg/runner/testdata/actions/node16/action.yml (+13 -0)
➕ pkg/runner/testdata/actions/node16/dist/index.js (+8666 -0)
➕ pkg/runner/testdata/actions/node16/index.js (+15 -0)
➕ pkg/runner/testdata/actions/node16/package-lock.json (+429 -0)
➕ pkg/runner/testdata/actions/node16/package.json (+23 -0)
📝 pkg/runner/testdata/basic/push.yml (+3 -3)
📝 pkg/runner/testdata/container-hostname/push.yml (+2 -2)

...and 7 more files

📄 Description

Changes:

Bump all images to NodeJS 16.x
Add support for node16 in actions

To do:

Add support to find the right version of node in the image for each node key
- node16 finds node in /opt/hostedtoolcache/node/16.*.*/, etc.
  this will be addressed in new PR

Closes #910

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/922 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 12/10/2021 **Status:** ✅ Merged **Merged:** 12/22/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `cat/feat/node16` --- ### 📝 Commits (7) - [`7daabd0`](https://github.com/nektos/act/commit/7daabd0cf1c67fad8bee6cba94f3232e4ea25845) feat: add node16 support - [`80f52a2`](https://github.com/nektos/act/commit/80f52a2aaf38992cefb77dd413ea904d4ba4073c) feat: bump images to node16 - [`1274576`](https://github.com/nektos/act/commit/1274576460860d34cf378b3032ff57a1a4eba686) lint(editorconfig): ignore *.md due to mixed style - [`3d79b55`](https://github.com/nektos/act/commit/3d79b55dd8d2805fce3e57c6fe9e43902c409586) Merge branch 'master' into cat/feat/node16 - [`0f4d75e`](https://github.com/nektos/act/commit/0f4d75eae1d2423b8d8c8d83af9bbfc27dc4df17) Merge branch 'master' into cat/feat/node16 - [`74684a6`](https://github.com/nektos/act/commit/74684a6d6d3480681d711fa516c5fecfd152a039) Merge branch 'master' into cat/feat/node16 - [`9428e91`](https://github.com/nektos/act/commit/9428e91abd10c477573fb3cd177f0ee26567b7c6) Merge branch 'master' into cat/feat/node16 ### 📊 Changes **27 files changed** (+9200 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `IMAGES.md` (+4 -0) 📝 `README.md` (+4 -4) 📝 `cmd/platforms.go` (+3 -3) 📝 `cmd/root.go` (+1 -1) 📝 `pkg/artifacts/server_test.go` (+1 -1) 📝 `pkg/container/docker_images_test.go` (+4 -4) 📝 `pkg/model/action.go` (+4 -1) 📝 `pkg/runner/runner_test.go` (+2 -2) 📝 `pkg/runner/step_context.go` (+2 -1) 📝 `pkg/runner/testdata/actions/docker-local/Dockerfile` (+1 -1) 📝 `pkg/runner/testdata/actions/docker-url/action.yml` (+1 -1) 📝 `pkg/runner/testdata/actions/node12/package.json` (+3 -0) ➕ `pkg/runner/testdata/actions/node16/README.md` (+3 -0) ➕ `pkg/runner/testdata/actions/node16/action.yml` (+13 -0) ➕ `pkg/runner/testdata/actions/node16/dist/index.js` (+8666 -0) ➕ `pkg/runner/testdata/actions/node16/index.js` (+15 -0) ➕ `pkg/runner/testdata/actions/node16/package-lock.json` (+429 -0) ➕ `pkg/runner/testdata/actions/node16/package.json` (+23 -0) 📝 `pkg/runner/testdata/basic/push.yml` (+3 -3) 📝 `pkg/runner/testdata/container-hostname/push.yml` (+2 -2) _...and 7 more files_ </details> ### 📄 Description Changes: - Bump all images to NodeJS 16.x - Add support for `node16` in actions To do: - Add support to find the right version of node in the image for each node key - `node16` finds node in `/opt/hostedtoolcache/node/16.*.*/`, etc. this will be addressed in new PR Closes #910 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:14 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1684

No description provided.

Rows
Columns