[PR #898] [MERGED] feat: allow existing logger from context #1673

New issue

Closed

opened 2026-03-01 21:52:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/898
Author: @ZauberNerd
Created: 11/22/2021
Status: ✅ Merged
Merged: 11/27/2021
Merged by: @mergify[bot]

Base: master ← Head: reuse-logger

📝 Commits (1)

be91b48 feat: allow existing logger from context

📊 Changes

2 files changed (+26 additions, -0 deletions)

View changed files

➕ pkg/common/testflag.go (+20 -0)
📝 pkg/runner/logger.go (+6 -0)

📄 Description

We should reuse an existing context logger if in test context.
This will allow test to setup act with a null logger to assert
log messages.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/898 **Author:** [@ZauberNerd](https://github.com/ZauberNerd) **Created:** 11/22/2021 **Status:** ✅ Merged **Merged:** 11/27/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `reuse-logger` --- ### 📝 Commits (1) - [`be91b48`](https://github.com/nektos/act/commit/be91b48d53962f38c563850e86878762beadbba7) feat: allow existing logger from context ### 📊 Changes **2 files changed** (+26 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `pkg/common/testflag.go` (+20 -0) 📝 `pkg/runner/logger.go` (+6 -0) </details> ### 📄 Description We should reuse an existing context logger if in test context. This will allow test to setup act with a null logger to assert log messages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:11 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1673

No description provided.

Rows
Columns