[PR #894] [MERGED] Don't interpolate joboutputs, before job is done #1672

Closed
opened 2026-03-01 21:52:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/894
Author: @BlackDex
Created: 11/20/2021
Status: Merged
Merged: 11/24/2021
Merged by: @mergify[bot]

Base: masterHead: output-fix


📝 Commits (3)

📊 Changes

4 files changed (+60 additions, -15 deletions)

View changed files

📝 pkg/runner/run_context.go (+16 -2)
📝 pkg/runner/runner_test.go (+1 -0)
📝 pkg/runner/step_context.go (+0 -13)
pkg/runner/testdata/outputs/push.yml (+43 -0)

📄 Description

All credits go to @ChristopherHX which fixed this issue (github.com/ChristopherHX/act@fd9f40cdc0).
I only created a PR for this so it will be fixed in the upstream binary.

This fixes #758


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/894 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 11/20/2021 **Status:** ✅ Merged **Merged:** 11/24/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `output-fix` --- ### 📝 Commits (3) - [`bf47482`](https://github.com/nektos/act/commit/bf4748254627ff8c8598c7e97cf549c76bc6afa0) Don't interpolate joboutputs, before job is donei - [`5c08ced`](https://github.com/nektos/act/commit/5c08ced40da8d515b3c55a2f311bc8e32f5b5909) Added output test - [`3e2739a`](https://github.com/nektos/act/commit/3e2739a8c96dece7ba92d8ae07392e36df87aaa4) Fix typo ### 📊 Changes **4 files changed** (+60 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+16 -2) 📝 `pkg/runner/runner_test.go` (+1 -0) 📝 `pkg/runner/step_context.go` (+0 -13) ➕ `pkg/runner/testdata/outputs/push.yml` (+43 -0) </details> ### 📄 Description All credits go to @ChristopherHX which fixed this issue (https://github.com/ChristopherHX/act/commit/fd9f40cdc02dc72c40a9c33450d638d6e8e8ee57). I only created a PR for this so it will be fixed in the upstream binary. This fixes #758 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:52:10 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1672
No description provided.