[PR #893] [MERGED] Fix regex for GITHUB_ENV parsing #1671

Closed
opened 2026-03-01 21:52:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/893
Author: @catthehacker
Created: 11/19/2021
Status: Merged
Merged: 11/19/2021
Merged by: @mergify[bot]

Base: masterHead: cat/fix/github-env-regex


📝 Commits (3)

  • 03dc4ee fix: correct env pattern regex
  • 20eb069 format: format and typo fix
  • 3d31b76 Merge branch 'master' into cat/fix/github-env-regex

📊 Changes

2 files changed (+15 additions, -5 deletions)

View changed files

📝 pkg/container/docker_run.go (+4 -1)
📝 pkg/runner/testdata/env-and-path/push.yaml (+11 -4)

📄 Description

While troubleshooting cachix/install-nix-action (https://github.com/cachix/install-nix-action/pull/111) we hit a bug where envvars in $GITHUB_ENV file that contain equals sign (=) do not work
This PR fixes that issue


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/893 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 11/19/2021 **Status:** ✅ Merged **Merged:** 11/19/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `cat/fix/github-env-regex` --- ### 📝 Commits (3) - [`03dc4ee`](https://github.com/nektos/act/commit/03dc4eed47bfbd7716d265b85dc6ddf321653f44) fix: correct env pattern regex - [`20eb069`](https://github.com/nektos/act/commit/20eb069f26d477f5a3166e45c97878fadcae6c01) format: format and typo fix - [`3d31b76`](https://github.com/nektos/act/commit/3d31b762fdd1b0aec6fbf422590880183e4cdef2) Merge branch 'master' into cat/fix/github-env-regex ### 📊 Changes **2 files changed** (+15 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+4 -1) 📝 `pkg/runner/testdata/env-and-path/push.yaml` (+11 -4) </details> ### 📄 Description While troubleshooting `cachix/install-nix-action` (https://github.com/cachix/install-nix-action/pull/111) we hit a bug where envvars in `$GITHUB_ENV` file that contain equals sign (`=`) do not work This PR fixes that issue --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:52:10 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1671
No description provided.