[PR #890] [MERGED] Revert "feat: allow existing logger from context" #1670

New issue

Closed

opened 2026-03-01 21:52:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/890
Author: @catthehacker
Created: 11/17/2021
Status: ✅ Merged
Merged: 11/19/2021
Merged by: @mergify[bot]

Base: master ← Head: revert-859-reuse-logger

📝 Commits (1)

22c547e Revert "feat: allow existing logger from context (#859)"

📊 Changes

1 file changed (+1 additions, -8 deletions)

View changed files

📝 pkg/runner/logger.go (+1 -8)

📄 Description

Reverts nektos/act#859
That PR broke colours for jobs and prints nils for certain lines (see above PR for context)

note for me (and maybe others): verify future PRs touching loggers on local machine

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/890 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 11/17/2021 **Status:** ✅ Merged **Merged:** 11/19/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `revert-859-reuse-logger` --- ### 📝 Commits (1) - [`22c547e`](https://github.com/nektos/act/commit/22c547e14f632bc5685dc4c0739d008447580c43) Revert "feat: allow existing logger from context (#859)" ### 📊 Changes **1 file changed** (+1 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/logger.go` (+1 -8) </details> ### 📄 Description Reverts nektos/act#859 That PR broke colours for jobs and prints `nil`s for certain lines (see above PR for context) note for me (and maybe others): verify future PRs touching loggers on local machine --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:10 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:51 +03:00

[PR #1670] [MERGED] full path required for extension install #2063

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1670

No description provided.

Rows
Columns