[PR #857] [CLOSED] lint: make shellcheck happier #1650

New issue

Closed

opened 2026-03-01 21:52:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/857
Author: @jsoref
Created: 11/2/2021
Status: ❌ Closed

Base: master ← Head: actionlinter-shellcheck

📝 Commits (1)

1c8c7a7 lint: make shellcheck happier

📊 Changes

1 file changed (+7 additions, -7 deletions)

View changed files

📝 .github/workflows/checks.yml (+7 -7)

📄 Description

I'm not a huge fan of linters, but when I tried to run make, I tripped over a bunch of things. After a bit of thought, I eventually figured out some of them...

Sprinkling some quotation marks here seems like a reasonable compromise.

Note: I can't figure out how to make the linter happy about: for image in ${{ env.CACHED_DOCKER_IMAGES }} -- it is confident that the thing after in is a single value and not possibly multiple values. I suspect it's possible to trick it by writing that item to a file and then using cat to retrieve the contents of the file, but that seems quite a bit much.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/857 **Author:** [@jsoref](https://github.com/jsoref) **Created:** 11/2/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `actionlinter-shellcheck` --- ### 📝 Commits (1) - [`1c8c7a7`](https://github.com/nektos/act/commit/1c8c7a751a729e0f144efe5e957959d9a0d49763) lint: make shellcheck happier ### 📊 Changes **1 file changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/checks.yml` (+7 -7) </details> ### 📄 Description I'm not a huge fan of linters, but when I tried to run `make`, I tripped over a bunch of things. After a bit of thought, I eventually figured out some of them... Sprinkling some quotation marks here seems like a reasonable compromise. Note: I can't figure out how to make the linter happy about: `for image in ${{ env.CACHED_DOCKER_IMAGES }}` -- it is confident that the thing after `in` is a single value and not possibly multiple values. I suspect it's possible to trick it by writing that item to a file and then using `cat` to retrieve the contents of the file, but that seems quite a bit much. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:05 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:49 +03:00

[PR #1650] [MERGED] build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 #2054

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1650

No description provided.

Rows
Columns