starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 01:15:51 +03:00

[PR #853] [MERGED] fix: set `sh` as default shell for containers #1645

New issue

Closed

opened 2026-03-01 21:52:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/853
Author: @catthehacker
Created: 10/31/2021
Status: ✅ Merged
Merged: 11/3/2021
Merged by: @cplee

Base: master ← Head: cat/fix/default-shell

📝 Commits (2)

97683d8 fix: set default shell for containers to sh
19127f3 tests: fixup for default shell

📊 Changes

8 files changed (+76 additions, -3 deletions)

View changed files

📝 pkg/runner/runner_test.go (+1 -0)
📝 pkg/runner/step_context.go (+6 -0)
📝 pkg/runner/testdata/container-hostname/push.yml (+4 -0)
📝 pkg/runner/testdata/shells/bash/push.yml (+15 -2)
➕ pkg/runner/testdata/shells/defaults/push.yml (+21 -0)
📝 pkg/runner/testdata/shells/pwsh/push.yml (+7 -0)
📝 pkg/runner/testdata/shells/python/push.yml (+8 -0)
📝 pkg/runner/testdata/shells/sh/push.yml (+14 -1)

📄 Description

fix: set default shell for containers to sh
This matches GitHub Actions behaviour where, runners use bash since it's guaranteed to exist there while containers use sh for compatibility

tests: fixup for default shell

fixes #850

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/853 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 10/31/2021 **Status:** ✅ Merged **Merged:** 11/3/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `cat/fix/default-shell` --- ### 📝 Commits (2) - [`97683d8`](https://github.com/nektos/act/commit/97683d8bff6b278c8c31dfe4583727f012cda098) fix: set default shell for containers to sh - [`19127f3`](https://github.com/nektos/act/commit/19127f3ec7fe0ee04c4d91db21a4eb33ad213e54) tests: fixup for default shell ### 📊 Changes **8 files changed** (+76 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/runner_test.go` (+1 -0) 📝 `pkg/runner/step_context.go` (+6 -0) 📝 `pkg/runner/testdata/container-hostname/push.yml` (+4 -0) 📝 `pkg/runner/testdata/shells/bash/push.yml` (+15 -2) ➕ `pkg/runner/testdata/shells/defaults/push.yml` (+21 -0) 📝 `pkg/runner/testdata/shells/pwsh/push.yml` (+7 -0) 📝 `pkg/runner/testdata/shells/python/push.yml` (+8 -0) 📝 `pkg/runner/testdata/shells/sh/push.yml` (+14 -1) </details> ### 📄 Description fix: set default shell for containers to `sh` This matches GitHub Actions behaviour where, runners use `bash` since it's guaranteed to exist there while containers use `sh` for compatibility tests: fixup for default shell fixes #850 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:04 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:47 +03:00

[PR #1645] [MERGED] fix: compare properties of Invalid types #2049

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1645

No description provided.

Rows
Columns

[PR #853] [MERGED] fix: set sh as default shell for containers #1645

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description

[PR #853] [MERGED] fix: set `sh` as default shell for containers #1645