[PR #823] [MERGED] fix: add simple concurrency limit #1628

Closed
opened 2026-03-01 21:51:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/823
Author: @catthehacker
Created: 9/24/2021
Status: Merged
Merged: 9/26/2021
Merged by: @mergify[bot]

Base: masterHead: cat/fix/simple-concurrency


📝 Commits (3)

  • f19c431 fix: add simple concurrency limit
  • 01259fc Merge branch 'master' into cat/fix/simple-concurrency
  • fc3496f Merge branch 'master' into cat/fix/simple-concurrency

📊 Changes

1 file changed (+15 additions, -1 deletions)

View changed files

📝 pkg/runner/runner.go (+15 -1)

📄 Description

Adds concurrency limit based on max-parallel key from strategy
In case of missing key, it uses default value 4
If there is less jobs than default max parallel, it will set max parallel to count of jobs.

Currently it will run max parallel jobs, wait for finish, then start another batch of jobs.

Related issue: https://github.com/nektos/act/issues/158

TODO: job.Strategy should always be available even if it's not specified in workflow, so then we won't have to redefine maxParallel limit to 4


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/823 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 9/24/2021 **Status:** ✅ Merged **Merged:** 9/26/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `cat/fix/simple-concurrency` --- ### 📝 Commits (3) - [`f19c431`](https://github.com/nektos/act/commit/f19c431015f077bc7c4339da4d6331bbe717db46) fix: add simple concurrency limit - [`01259fc`](https://github.com/nektos/act/commit/01259fcbcd579aa4a75c48988f0a3596605b0cbe) Merge branch 'master' into cat/fix/simple-concurrency - [`fc3496f`](https://github.com/nektos/act/commit/fc3496f4fc65bf818d183620eb1f37191862f61b) Merge branch 'master' into cat/fix/simple-concurrency ### 📊 Changes **1 file changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/runner.go` (+15 -1) </details> ### 📄 Description Adds concurrency limit based on `max-parallel` key from `strategy` In case of missing key, it uses default value `4` If there is less jobs than default max parallel, it will set max parallel to count of jobs. Currently it will run max parallel jobs, wait for finish, then start another batch of jobs. Related issue: https://github.com/nektos/act/issues/158 TODO: `job.Strategy` should always be available even if it's not specified in workflow, so then we won't have to redefine `maxParallel` limit to `4` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1628
No description provided.