[PR #793] [MERGED] Feature: uses in composite #1611

New issue

Closed

opened 2026-03-01 21:51:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/793
Author: @ChristopherHX
Created: 8/30/2021
Status: ✅ Merged
Merged: 12/22/2021
Merged by: @mergify[bot]

Base: master ← Head: feature/uses-in-composite

📝 Commits (10+)

6d6934b Feature: uses in composite
9f8d9dd Negate logic
87485bc Reduce complexity
8ebd0be Update step_context.go
d4c34ea Update step_context.go
216a146 Update step_context.go
bd0d659 Fix syntax error in test
576c2f7 Bump
4817da7 Disable usage of actions/setup-node@v2
bee1aa0 Bump

📊 Changes

19 files changed (+463 additions, -157 deletions)

View changed files

📝 pkg/model/action.go (+12 -1)
📝 pkg/model/workflow.go (+25 -3)
📝 pkg/runner/expression.go (+7 -18)
📝 pkg/runner/run_context.go (+51 -19)
📝 pkg/runner/runner.go (+26 -25)
📝 pkg/runner/runner_test.go (+3 -0)
📝 pkg/runner/step_context.go (+124 -86)
➕ pkg/runner/testdata/actions/docker-local-noargs/Dockerfile (+8 -0)
➕ pkg/runner/testdata/actions/docker-local-noargs/action.yml (+15 -0)
➕ pkg/runner/testdata/actions/docker-local-noargs/entrypoint.sh (+8 -0)
📝 pkg/runner/testdata/local-action-dockerfile/push.yml (+9 -0)
➕ pkg/runner/testdata/local-action-via-composite-dockerfile/action.yml (+44 -0)
➕ pkg/runner/testdata/local-action-via-composite-dockerfile/push.yml (+9 -0)
➕ pkg/runner/testdata/uses-composite-with-error/composite_action2/action.yml (+11 -0)
➕ pkg/runner/testdata/uses-composite-with-error/push.yml (+12 -0)
📝 pkg/runner/testdata/uses-composite/composite_action/action.yml (+9 -3)
📝 pkg/runner/testdata/uses-composite/push.yml (+12 -2)
➕ pkg/runner/testdata/uses-nested-composite/composite_action2/action.yml (+63 -0)
➕ pkg/runner/testdata/uses-nested-composite/push.yml (+15 -0)

📄 Description

Remove the old hack for composite run steps, use the real runcontext directly.
~~You can also enable if's in composite, I plan to enable it in https://github.com/ChristopherHX/github-act-runner by default.~~
If's are now enabled see https://github.com/actions/runner/releases/tag/v2.284.0

Resolves #783
Resolves #926

This change seems to be functional complete.
Multi nested composite needs more Tests, maybe the size will get xl after more tests are added.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/793 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 8/30/2021 **Status:** ✅ Merged **Merged:** 12/22/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `feature/uses-in-composite` --- ### 📝 Commits (10+) - [`6d6934b`](https://github.com/nektos/act/commit/6d6934b148262b2d0f29731c49209dccfc8b1674) Feature: uses in composite - [`9f8d9dd`](https://github.com/nektos/act/commit/9f8d9dd49ebd3d2571d03b370f95383512a3dc7b) Negate logic - [`87485bc`](https://github.com/nektos/act/commit/87485bcdf39a31956634a791f461a45be4c4892c) Reduce complexity - [`8ebd0be`](https://github.com/nektos/act/commit/8ebd0be6b35bd00d1aa2aed71b51aa81c391e9b3) Update step_context.go - [`d4c34ea`](https://github.com/nektos/act/commit/d4c34ea761997e2614cd6931dcc8e59224752e45) Update step_context.go - [`216a146`](https://github.com/nektos/act/commit/216a146be27dc89b3110d01dcd9cbdad64a06d9b) Update step_context.go - [`bd0d659`](https://github.com/nektos/act/commit/bd0d65921909ad0c40daa040b8b8343a1e039167) Fix syntax error in test - [`576c2f7`](https://github.com/nektos/act/commit/576c2f7d32cae0e2d2f0c99052eef099214e06fc) Bump - [`4817da7`](https://github.com/nektos/act/commit/4817da764ac35c67f16d40f4e0ce1406cba1b430) Disable usage of actions/setup-node@v2 - [`bee1aa0`](https://github.com/nektos/act/commit/bee1aa0b9bf417cc3cf7c9777e296cdaa45db728) Bump ### 📊 Changes **19 files changed** (+463 additions, -157 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/action.go` (+12 -1) 📝 `pkg/model/workflow.go` (+25 -3) 📝 `pkg/runner/expression.go` (+7 -18) 📝 `pkg/runner/run_context.go` (+51 -19) 📝 `pkg/runner/runner.go` (+26 -25) 📝 `pkg/runner/runner_test.go` (+3 -0) 📝 `pkg/runner/step_context.go` (+124 -86) ➕ `pkg/runner/testdata/actions/docker-local-noargs/Dockerfile` (+8 -0) ➕ `pkg/runner/testdata/actions/docker-local-noargs/action.yml` (+15 -0) ➕ `pkg/runner/testdata/actions/docker-local-noargs/entrypoint.sh` (+8 -0) 📝 `pkg/runner/testdata/local-action-dockerfile/push.yml` (+9 -0) ➕ `pkg/runner/testdata/local-action-via-composite-dockerfile/action.yml` (+44 -0) ➕ `pkg/runner/testdata/local-action-via-composite-dockerfile/push.yml` (+9 -0) ➕ `pkg/runner/testdata/uses-composite-with-error/composite_action2/action.yml` (+11 -0) ➕ `pkg/runner/testdata/uses-composite-with-error/push.yml` (+12 -0) 📝 `pkg/runner/testdata/uses-composite/composite_action/action.yml` (+9 -3) 📝 `pkg/runner/testdata/uses-composite/push.yml` (+12 -2) ➕ `pkg/runner/testdata/uses-nested-composite/composite_action2/action.yml` (+63 -0) ➕ `pkg/runner/testdata/uses-nested-composite/push.yml` (+15 -0) </details> ### 📄 Description Remove the old hack for composite run steps, use the real runcontext directly. ~~You can also enable if's in composite, I plan to enable it in https://github.com/ChristopherHX/github-act-runner by default.~~ If's are now enabled see https://github.com/actions/runner/releases/tag/v2.284.0 Resolves #783 Resolves #926 This change seems to be functional complete. Multi nested composite needs more Tests, maybe the size will get xl after more tests are added. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:54 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:43 +03:00

[PR #1611] [MERGED] build(deps): bump github.com/docker/cli from 23.0.0-rc.1+incompatible to 23.0.0+incompatible #2030

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1611

No description provided.

Rows
Columns