[PR #775] [CLOSED] Add support for GHA services #1602

New issue

Closed

opened 2026-03-01 21:51:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/775
Author: @catthehacker
Created: 8/11/2021
Status: ❌ Closed

Base: master ← Head: cat/feat/services

📝 Commits (7)

e7e647d Draft: Adds services capabilities
cf863d5 Applies review changes
6ec8c24 Removes unnecessary log line
faf60a9 Removes old code induced because of the rebase
ada1375 Update pkg/runner/runner_test.go
079c613 fix: rework services
90a47e9 fixup! fix: rework services

📊 Changes

5 files changed (+404 additions, -68 deletions)

View changed files

➕ pkg/container/docker_network.go (+71 -0)
📝 pkg/container/docker_run.go (+83 -24)
📝 pkg/runner/run_context.go (+173 -44)
📝 pkg/runner/runner_test.go (+36 -0)
➕ pkg/runner/testdata/services/push.yaml (+41 -0)

📄 Description

Original PR: https://github.com/nektos/act/pull/638
Fixes https://github.com/nektos/act/issues/173

Changes:

add support for services
creates network linked between all containers
fixes job context to include container and services contexts

To do:

Add more testcases
Multiple sanity checks that code doesn't look terrible
Fix job context

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/775 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 8/11/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cat/feat/services` --- ### 📝 Commits (7) - [`e7e647d`](https://github.com/nektos/act/commit/e7e647d3dff7134628c15c0c256a0b7bd362d78f) Draft: Adds services capabilities - [`cf863d5`](https://github.com/nektos/act/commit/cf863d5bef522284ae9b6bcbc8d0d792a107b74a) Applies review changes - [`6ec8c24`](https://github.com/nektos/act/commit/6ec8c24e4c331b41d0ca8e2f42126ff40eab35ec) Removes unnecessary log line - [`faf60a9`](https://github.com/nektos/act/commit/faf60a9e5668a17a72a91fdb3c02ab7482bd1b1d) Removes old code induced because of the rebase - [`ada1375`](https://github.com/nektos/act/commit/ada1375def3ad6e1411ddb933ef6c230d5737110) Update pkg/runner/runner_test.go - [`079c613`](https://github.com/nektos/act/commit/079c6130210e241baaf8e6b92e90bb975eab440c) fix: rework services - [`90a47e9`](https://github.com/nektos/act/commit/90a47e9b2f0277fdb6941b635345854b1921acbc) fixup! fix: rework services ### 📊 Changes **5 files changed** (+404 additions, -68 deletions) <details> <summary>View changed files</summary> ➕ `pkg/container/docker_network.go` (+71 -0) 📝 `pkg/container/docker_run.go` (+83 -24) 📝 `pkg/runner/run_context.go` (+173 -44) 📝 `pkg/runner/runner_test.go` (+36 -0) ➕ `pkg/runner/testdata/services/push.yaml` (+41 -0) </details> ### 📄 Description Original PR: https://github.com/nektos/act/pull/638 Fixes https://github.com/nektos/act/issues/173 Changes: - add support for `services` - creates network linked between all containers - fixes job context to include container and services contexts To do: - [x] Add more testcases - [x] Multiple sanity checks that code doesn't look terrible - [ ] Fix job context --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:52 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1602

No description provided.

Rows
Columns