[PR #767] [MERGED] Fix docker: invalid reference format #1596

New issue

Closed

opened 2026-03-01 21:51:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/767
Author: @ChristopherHX
Created: 8/8/2021
Status: ✅ Merged
Merged: 8/9/2021
Merged by: @mergify[bot]

Base: master ← Head: fix/invalid-reference-format

📝 Commits (9)

8608933 Fix local Docker actions: invalid reference format
9d1dbbc Create Dockerfile
1f05c37 Create Dockerfile
8c32e84 Update push.yml
f8efae5 Revert "Create Dockerfile"
e332c66 Fix lint
1150eb9 fix: re-use image that is already present in repo
fccef88 fix: revert change
079c8ae Merge branch 'master' into fix/invalid-reference-format

📊 Changes

3 files changed (+5 additions, -1 deletions)

View changed files

📝 pkg/runner/step_context.go (+2 -1)
📝 pkg/runner/testdata/local-action-dockerfile/push.yml (+1 -0)
➕ pkg/runner/testdata/localdockerimagetest_/Dockerfile (+2 -0)

📄 Description

Added a test to enshure that docker actions with names ending by anything which matches against [^a-zA-Z0-9] will still generate a valid docker container name.

./test_ would get image name like act-test-:latest => docker fails without this change

Fixes #744
Fixes #756

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/767 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 8/8/2021 **Status:** ✅ Merged **Merged:** 8/9/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix/invalid-reference-format` --- ### 📝 Commits (9) - [`8608933`](https://github.com/nektos/act/commit/8608933105c1fce914c5f3c3f98f6addb2a644a4) Fix local Docker actions: invalid reference format - [`9d1dbbc`](https://github.com/nektos/act/commit/9d1dbbc2c7fdf52963e55feb4148ac2b14d639d0) Create Dockerfile - [`1f05c37`](https://github.com/nektos/act/commit/1f05c372c9dae95ef6469726a5f928c820c2e788) Create Dockerfile - [`8c32e84`](https://github.com/nektos/act/commit/8c32e84322e58482a13c07e31b4fca1e08bfd276) Update push.yml - [`f8efae5`](https://github.com/nektos/act/commit/f8efae5d03e7c5e70a32b172d0bbfd10334dc3ad) Revert "Create Dockerfile" - [`e332c66`](https://github.com/nektos/act/commit/e332c667c54f991386843aa62a1a751a6b52adf6) Fix lint - [`1150eb9`](https://github.com/nektos/act/commit/1150eb963a7c02802db214cf6c26c2b85594e85e) fix: re-use image that is already present in repo - [`fccef88`](https://github.com/nektos/act/commit/fccef88dcf9203a00b5d39820c3f90e014af4edf) fix: revert change - [`079c8ae`](https://github.com/nektos/act/commit/079c8ae25ccc16c4d71b7cba9c79b89a38da6acc) Merge branch 'master' into fix/invalid-reference-format ### 📊 Changes **3 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/step_context.go` (+2 -1) 📝 `pkg/runner/testdata/local-action-dockerfile/push.yml` (+1 -0) ➕ `pkg/runner/testdata/localdockerimagetest_/Dockerfile` (+2 -0) </details> ### 📄 Description Added a test to enshure that docker actions with names ending by anything which matches against `[^a-zA-Z0-9]` will still generate a valid docker container name. `./test_` would get image name like `act-test-:latest` => docker fails without this change Fixes #744 Fixes #756 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:51 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:40 +03:00

[PR #1596] [MERGED] Docker build fixes #2021

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1596

No description provided.

Rows
Columns