[PR #763] [MERGED] Simplify Matrix decode, add defaults for fail-fast and max-parallel, add test #1594

New issue

Closed

opened 2026-03-01 21:51:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/763
Author: @catthehacker
Created: 7/26/2021
Status: ✅ Merged
Merged: 8/9/2021
Merged by: @mergify[bot]

Base: master ← Head: cat/fix/strategy

📝 Commits (3)

aa0d7b5 fix[workflow]: multiple fixes for workflow/matrix
7717208 fix(workflow): use yaml node for env key
e3eb7df Merge branch 'master' into cat/fix/strategy

📊 Changes

6 files changed (+236 additions, -72 deletions)

View changed files

➕ pkg/model/testdata/strategy/push.yml (+50 -0)
📝 pkg/model/workflow.go (+109 -64)
📝 pkg/model/workflow_test.go (+58 -0)
📝 pkg/runner/expression_test.go (+9 -4)
📝 pkg/runner/run_context_test.go (+9 -4)
📝 pkg/runner/runner_test.go (+1 -0)

📄 Description

fix[workflow]: default max-parallel
fix[workflow]: default fail-fast, it's true, not false
fix[workflow]: skipping over the job when strategy: is defined but matrix: isn't (fixes #625)
fix[workflow]: skip non-existing includes keys and hard fail on non-existing excludes keys
fix[workflow]: simplify Matrix decode (because I "think" I know how yaml works) (fixes #760)
fix[tests]: add test for planner and runner

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/763 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 7/26/2021 **Status:** ✅ Merged **Merged:** 8/9/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `cat/fix/strategy` --- ### 📝 Commits (3) - [`aa0d7b5`](https://github.com/nektos/act/commit/aa0d7b5f919acb4d53ca9c53efb3e247710ee929) fix[workflow]: multiple fixes for workflow/matrix - [`7717208`](https://github.com/nektos/act/commit/77172082408c8b3849120c99afead80e3ce200e7) fix(workflow): use yaml node for env key - [`e3eb7df`](https://github.com/nektos/act/commit/e3eb7df4b3ddd0597f6e8cc433c2934e9627808b) Merge branch 'master' into cat/fix/strategy ### 📊 Changes **6 files changed** (+236 additions, -72 deletions) <details> <summary>View changed files</summary> ➕ `pkg/model/testdata/strategy/push.yml` (+50 -0) 📝 `pkg/model/workflow.go` (+109 -64) 📝 `pkg/model/workflow_test.go` (+58 -0) 📝 `pkg/runner/expression_test.go` (+9 -4) 📝 `pkg/runner/run_context_test.go` (+9 -4) 📝 `pkg/runner/runner_test.go` (+1 -0) </details> ### 📄 Description fix[workflow]: default `max-parallel` fix[workflow]: default `fail-fast`, it's `true`, not `false` fix[workflow]: skipping over the job when `strategy:` is defined but `matrix:` isn't (fixes #625) fix[workflow]: skip non-existing includes keys and hard fail on non-existing excludes keys fix[workflow]: simplify Matrix decode (because I "think" I know how `yaml` works) (fixes #760) fix[tests]: add test for planner and runner --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:41 +03:00

[PR #1599] [MERGED] fix: Apply forcePull only for prebuild docker actions #2024

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1594

No description provided.

Rows
Columns