[PR #753] [MERGED] Fix defaults (composite) #1591

New issue

Closed

opened 2026-03-01 21:51:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/753
Author: @ChristopherHX
Created: 7/16/2021
Status: ✅ Merged
Merged: 7/21/2021
Merged by: @mergify[bot]

Base: master ← Head: fix/composite-defaults

📝 Commits (4)

81af550 Fix defaults (composite)
c191b8e uses-composite: rely on defaults to pass
fd961cf Add test_input_required back, needs more tests
dbc67c5 Update Tests to test defaults carefully

📊 Changes

4 files changed (+50 additions, -1 deletions)

View changed files

📝 pkg/runner/expression.go (+1 -1)
📝 pkg/runner/step_context.go (+1 -0)
📝 pkg/runner/testdata/uses-composite/composite_action/action.yml (+33 -0)
📝 pkg/runner/testdata/uses-composite/push.yml (+15 -0)

📄 Description

Missing assignment in runcontext copy caused missing defaults in vmInputs.
Also vmInputs needs interpolation of the default value, like the INPUT_ env variables

Resolves #655

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/753 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 7/16/2021 **Status:** ✅ Merged **Merged:** 7/21/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix/composite-defaults` --- ### 📝 Commits (4) - [`81af550`](https://github.com/nektos/act/commit/81af5503936dd99d3f5afe0f0930752f00598298) Fix defaults (composite) - [`c191b8e`](https://github.com/nektos/act/commit/c191b8e691c7251fba67b6a45e3ecfcfae8c52d7) uses-composite: rely on defaults to pass - [`fd961cf`](https://github.com/nektos/act/commit/fd961cfda2f57e74bf18fe66519c3120df534671) Add test_input_required back, needs more tests - [`dbc67c5`](https://github.com/nektos/act/commit/dbc67c5fc5fb4697280ae744514bc14fdc87fe46) Update Tests to test defaults carefully ### 📊 Changes **4 files changed** (+50 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/expression.go` (+1 -1) 📝 `pkg/runner/step_context.go` (+1 -0) 📝 `pkg/runner/testdata/uses-composite/composite_action/action.yml` (+33 -0) 📝 `pkg/runner/testdata/uses-composite/push.yml` (+15 -0) </details> ### 📄 Description Missing assignment in runcontext copy caused missing defaults in vmInputs. Also vmInputs needs interpolation of the default value, like the INPUT_ env variables Resolves #655 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:49 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1591

No description provided.

Rows
Columns