[PR #750] [CLOSED] Add more tests #1588

New issue

Closed

opened 2026-03-01 21:51:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/750
Author: @catthehacker
Created: 7/7/2021
Status: ❌ Closed

Base: master ← Head: cat/fix/coverage

📝 Commits (5)

db0017b fix: add draw_test.go tests
298eedd fix: add dryrun tests
55d3933 fix: add tests
eb546de Merge branch 'master' into cat/fix/coverage
2e7d07e Merge branch 'master' into cat/fix/coverage

📊 Changes

7 files changed (+283 additions, -87 deletions)

View changed files

➕ pkg/common/draw_test.go (+63 -0)
➕ pkg/common/dryrun_test.go (+17 -0)
📝 pkg/model/planner.go (+4 -4)
➕ pkg/model/testdata/complete-workflow/main.yml (+75 -0)
➕ pkg/model/testdata/invalid-step-definition/push.yml (+16 -0)
📝 pkg/model/workflow.go (+9 -6)
📝 pkg/model/workflow_test.go (+99 -77)

📄 Description

add draw_test.go tests
add dryrun tests
add tests for environment func
remove unnecessary loop when reflecting and add default return
unexport fixIfStatement1 and add better description
minify workflows in tests and move some of them into one file

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/750 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 7/7/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cat/fix/coverage` --- ### 📝 Commits (5) - [`db0017b`](https://github.com/nektos/act/commit/db0017b11b0829292efff963dcd81cf850b4eff0) fix: add `draw_test.go` tests - [`298eedd`](https://github.com/nektos/act/commit/298eeddf34c58ff183c310af8284e6fe6ee9eb7a) fix: add dryrun tests - [`55d3933`](https://github.com/nektos/act/commit/55d39330adb5d8bffeda337f52e76df0fee94376) fix: add tests - [`eb546de`](https://github.com/nektos/act/commit/eb546de2ebc62e23ff1ff0b32e44f5cbad91318d) Merge branch 'master' into cat/fix/coverage - [`2e7d07e`](https://github.com/nektos/act/commit/2e7d07e4f3eddcfdeddafab752f1c41afaa54760) Merge branch 'master' into cat/fix/coverage ### 📊 Changes **7 files changed** (+283 additions, -87 deletions) <details> <summary>View changed files</summary> ➕ `pkg/common/draw_test.go` (+63 -0) ➕ `pkg/common/dryrun_test.go` (+17 -0) 📝 `pkg/model/planner.go` (+4 -4) ➕ `pkg/model/testdata/complete-workflow/main.yml` (+75 -0) ➕ `pkg/model/testdata/invalid-step-definition/push.yml` (+16 -0) 📝 `pkg/model/workflow.go` (+9 -6) 📝 `pkg/model/workflow_test.go` (+99 -77) </details> ### 📄 Description - add draw_test.go tests - add dryrun tests - add tests for environment func - remove unnecessary loop when reflecting and add default return - unexport fixIfStatement1 and add better description - minify workflows in tests and move some of them into one file --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:49 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:07 +03:00

[PR #1784] [MERGED] fix: remove hardcoded reference to github.com when using reusable remote workflows and remote actions #2127

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1588

No description provided.

Rows
Columns