[PR #719] [MERGED] Read local actions from docker container #1576

Closed
opened 2026-03-01 21:51:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/719
Author: @ChristopherHX
Created: 6/3/2021
Status: Merged
Merged: 8/3/2021
Merged by: @mergify[bot]

Base: masterHead: refactor/actions2


📝 Commits (4)

  • f7b9021 Read localaction's from container
  • 08a148d Merge branch 'master' into refactor/actions2
  • 7f9d96a Merge branch 'master' into refactor/actions2
  • ca87be4 Merge branch 'master' into refactor/actions2

📊 Changes

6 files changed (+65 additions, -16 deletions)

View changed files

📝 pkg/container/docker_build.go (+7 -2)
📝 pkg/container/docker_run.go (+6 -0)
📝 pkg/runner/step_context.go (+49 -14)
📝 pkg/runner/testdata/basic/push.yml (+1 -0)
📝 pkg/runner/testdata/parallel/push.yml (+1 -0)
📝 pkg/runner/testdata/uses-composite/push.yml (+1 -0)

📄 Description

Based on #712, with a lot of more changes to the behavior of act.
Depends on #712 to be ready for review, otherwise tests are failing.

Breaking changes

  • No localaction will run anymore if it doesn't exist inside the container (actions/checkout, git clone etc.).
    Changed tests to reflect this.
  • dry run won't work anymore for localactions

Resolves #550
Resolves #707

We can remove https://github.com/nektos/act#module_not_found from the readme as resolved.

Test artifacts of this PR (including #712), not rebased on master:
https://github.com/ChristopherHX/act/actions/runs/903050957


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/719 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 6/3/2021 **Status:** ✅ Merged **Merged:** 8/3/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `refactor/actions2` --- ### 📝 Commits (4) - [`f7b9021`](https://github.com/nektos/act/commit/f7b90211fb144e9cb906a72e45214a72ff583a41) Read localaction's from container - [`08a148d`](https://github.com/nektos/act/commit/08a148d3e95591d95ff3d0484d4b2bc0317285b4) Merge branch 'master' into refactor/actions2 - [`7f9d96a`](https://github.com/nektos/act/commit/7f9d96aae221ea2bcc129e416583b275af282652) Merge branch 'master' into refactor/actions2 - [`ca87be4`](https://github.com/nektos/act/commit/ca87be4d43560f5916b8e40e15e4d28af774a6c2) Merge branch 'master' into refactor/actions2 ### 📊 Changes **6 files changed** (+65 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_build.go` (+7 -2) 📝 `pkg/container/docker_run.go` (+6 -0) 📝 `pkg/runner/step_context.go` (+49 -14) 📝 `pkg/runner/testdata/basic/push.yml` (+1 -0) 📝 `pkg/runner/testdata/parallel/push.yml` (+1 -0) 📝 `pkg/runner/testdata/uses-composite/push.yml` (+1 -0) </details> ### 📄 Description Based on #712, with a lot of more changes to the behavior of act. **Depends on #712 to be ready for review**, otherwise tests are failing. **Breaking changes** - No localaction will run anymore if it doesn't exist inside the container (actions/checkout, git clone etc.). Changed tests to reflect this. - dry run won't work anymore for localactions Resolves #550 Resolves #707 We can remove https://github.com/nektos/act#module_not_found from the readme as resolved. Test artifacts of this PR (including #712), not rebased on master: https://github.com/ChristopherHX/act/actions/runs/903050957 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1576
No description provided.