[PR #709] [CLOSED] Fix actionPath to always end with actionName #1572

Closed
opened 2026-03-01 21:51:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/709
Author: @ChristopherHX
Created: 5/28/2021
Status: Closed

Base: masterHead: fix/invalid-action-path


📝 Commits (1)

  • 406a53a Fix actionPath to always end with actionName

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 pkg/runner/step_context.go (+3 -1)

📄 Description

Remove invalid workaround for local composite action
Resolves #708

I'm unshure why local actions are copied via docker cp, they should require the actions/checkout step.

  • Removing docker cp for localaction makes some parts of this pr redundant, so actionPath doesn't need to always end with actionName

- uses: ./ has an empty actionName, which is missing in containerActionDir

Replaced by #712


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/709 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 5/28/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/invalid-action-path` --- ### 📝 Commits (1) - [`406a53a`](https://github.com/nektos/act/commit/406a53a3b33c0ec378a0549bef5c13edf48e216b) Fix actionPath to always end with actionName ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/step_context.go` (+3 -1) </details> ### 📄 Description Remove invalid workaround for local composite action Resolves #708 I'm unshure why local actions are copied via docker cp, they should require the `actions/checkout` step. - Removing docker cp for localaction makes some parts of this pr redundant, so actionPath doesn't need to always end with actionName `- uses: ./` has an empty actionName, which is missing in containerActionDir **Replaced by #712** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1572
No description provided.