[PR #702] [MERGED] fix: avoid race condition by not running exec/start twice #1568

New issue

Closed

opened 2026-03-01 21:51:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/702
Author: @ZauberNerd
Created: 5/23/2021
Status: ✅ Merged
Merged: 5/25/2021
Merged by: @mergify[bot]

Base: master ← Head: fix-exec-already-running

📝 Commits (1)

22b45e3 fix: avoid race condition by not running exec/start twice

📊 Changes

1 file changed (+0 additions, -7 deletions)

View changed files

📝 pkg/container/docker_run.go (+0 -7)

📄 Description

ContainerExecAttach implicitly runs ContainerExecStart while attaching
to stdout/stderr.
Ref: github.com/moby/moby@e02bc91dcb/client/container_exec.go (L40)

Calling both can lead to a race condition as observed in #627

Fixes: #627

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/702 **Author:** [@ZauberNerd](https://github.com/ZauberNerd) **Created:** 5/23/2021 **Status:** ✅ Merged **Merged:** 5/25/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-exec-already-running` --- ### 📝 Commits (1) - [`22b45e3`](https://github.com/nektos/act/commit/22b45e36d71cf183977fbb7dac0b470a727f09d0) fix: avoid race condition by not running exec/start twice ### 📊 Changes **1 file changed** (+0 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+0 -7) </details> ### 📄 Description ContainerExecAttach implicitly runs ContainerExecStart while attaching to stdout/stderr. Ref: https://github.com/moby/moby/blob/e02bc91dcbf6ab70ab39352f3577a4394b0f863a/client/container_exec.go#L40 Calling both can lead to a race condition as observed in #627 Fixes: #627 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1568

No description provided.

Rows
Columns