[PR #688] [MERGED] refactor: remove `gotest.tools` #1562

New issue

Closed

opened 2026-03-01 21:51:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/688
Author: @catthehacker
Created: 5/17/2021
Status: ✅ Merged
Merged: 5/18/2021
Merged by: @cplee

Base: master ← Head: cat/refactor/testing

📝 Commits (2)

d7ffcf1 refactor: remove gotest.tools
87c1dc1 fix: handle more error cases

📊 Changes

9 files changed (+71 additions, -43 deletions)

View changed files

📝 .github/workflows/checks.yml (+1 -1)
📝 .golangci.yml (+21 -0)
📝 cmd/input.go (+2 -1)
📝 go.mod (+0 -1)
📝 pkg/container/docker_pull_test.go (+3 -3)
📝 pkg/runner/expression_test.go (+10 -10)
📝 pkg/runner/run_context_test.go (+8 -9)
📝 pkg/runner/runner_test.go (+16 -16)
📝 pkg/runner/step_context.go (+10 -2)

📄 Description

remove all references to gotest.tools and replace it with
github.com/stretchr/testify which was originally used for tests
bump golangci-lint version
add depguard and importas to prevent import of unwanted packages
add custom schema and information about config since
schemastore.org has broken schema for golangci-lint config

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/688 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 5/17/2021 **Status:** ✅ Merged **Merged:** 5/18/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `cat/refactor/testing` --- ### 📝 Commits (2) - [`d7ffcf1`](https://github.com/nektos/act/commit/d7ffcf13e1195c7d1a62ac71bd1b7522d191a7d3) refactor: remove `gotest.tools` - [`87c1dc1`](https://github.com/nektos/act/commit/87c1dc14f4bcfd7a2ae587365dd480fe0cf58ddc) fix: handle more error cases ### 📊 Changes **9 files changed** (+71 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/checks.yml` (+1 -1) 📝 `.golangci.yml` (+21 -0) 📝 `cmd/input.go` (+2 -1) 📝 `go.mod` (+0 -1) 📝 `pkg/container/docker_pull_test.go` (+3 -3) 📝 `pkg/runner/expression_test.go` (+10 -10) 📝 `pkg/runner/run_context_test.go` (+8 -9) 📝 `pkg/runner/runner_test.go` (+16 -16) 📝 `pkg/runner/step_context.go` (+10 -2) </details> ### 📄 Description * remove all references to `gotest.tools` and replace it with `github.com/stretchr/testify` which was originally used for tests * bump `golangci-lint` version * add `depguard` and `importas` to prevent import of unwanted packages * add custom schema and information about config since schemastore.org has broken schema for `golangci-lint` config --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:42 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:36 +03:00

[PR #1562] [MERGED] feat: add check for newer versions #2003

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1562

No description provided.

Rows
Columns

[PR #688] [MERGED] refactor: remove gotest.tools #1562

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description

[PR #688] [MERGED] refactor: remove `gotest.tools` #1562