[PR #679] [MERGED] Refactor `git` to add more errors, tests and specific GitHub Actions error #1556

New issue

Closed

opened 2026-03-01 21:51:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/679
Author: @catthehacker
Created: 5/8/2021
Status: ✅ Merged
Merged: 5/8/2021
Merged by: @mergify[bot]

Base: master ← Head: cat/fix/git-short-sha-error

📝 Commits (1)

3172d33 refactor: return more errors, add more tests

📊 Changes

6 files changed (+100 additions, -58 deletions)

View changed files

📝 pkg/common/git.go (+49 -41)
📝 pkg/common/git_test.go (+23 -11)
📝 pkg/runner/step_context.go (+11 -6)
📝 pkg/runner/step_context_test.go (+3 -0)
➕ pkg/runner/testdata/uses-github-full-sha/main.yml (+7 -0)
➕ pkg/runner/testdata/uses-github-short-sha/main.yml (+7 -0)

📄 Description

refactor: return more errors, add more tests
adding more tests
returns same message for short SHA format like GitHub Actions
refactor error checking
add more errors :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/679 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 5/8/2021 **Status:** ✅ Merged **Merged:** 5/8/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `cat/fix/git-short-sha-error` --- ### 📝 Commits (1) - [`3172d33`](https://github.com/nektos/act/commit/3172d33a63e71f0fa8097f81d30da9f0154b0281) refactor: return more errors, add more tests ### 📊 Changes **6 files changed** (+100 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `pkg/common/git.go` (+49 -41) 📝 `pkg/common/git_test.go` (+23 -11) 📝 `pkg/runner/step_context.go` (+11 -6) 📝 `pkg/runner/step_context_test.go` (+3 -0) ➕ `pkg/runner/testdata/uses-github-full-sha/main.yml` (+7 -0) ➕ `pkg/runner/testdata/uses-github-short-sha/main.yml` (+7 -0) </details> ### 📄 Description refactor: return more errors, add more tests adding more tests returns same message for short SHA format like GitHub Actions refactor error checking add more errors :) ![image](https://user-images.githubusercontent.com/31106839/117520734-0cdc5700-afaa-11eb-8c92-cbb5c402f374.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:40 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1556

No description provided.

Rows
Columns

[PR #679] [MERGED] Refactor git to add more errors, tests and specific GitHub Actions error #1556

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #679] [MERGED] Refactor `git` to add more errors, tests and specific GitHub Actions error #1556