[PR #668] [MERGED] fix: hide masked value #1549

New issue

Closed

opened 2026-03-01 21:51:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/668
Author: @KnisterPeter
Created: 5/6/2021
Status: ✅ Merged
Merged: 5/15/2021
Merged by: @mergify[bot]

Base: master ← Head: hidden-masked-values

📝 Commits (3)

22ecc08 fix: hide masked value
7e303eb Add test to not output secret in add-mask command
2d0680a Merge branch 'master' into hidden-masked-values

📊 Changes

2 files changed (+17 additions, -1 deletions)

View changed files

📝 pkg/runner/command.go (+1 -1)
📝 pkg/runner/command_test.go (+16 -0)

📄 Description

The ::add-mask:: command output logs the value to be masked.

The current implementation does expose critical information which should be hidden from the output.

Note: This PR does not implement proper mask handling. It just suppresses the output of the secret in the add-mask command.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/668 **Author:** [@KnisterPeter](https://github.com/KnisterPeter) **Created:** 5/6/2021 **Status:** ✅ Merged **Merged:** 5/15/2021 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `hidden-masked-values` --- ### 📝 Commits (3) - [`22ecc08`](https://github.com/nektos/act/commit/22ecc0829efbd75e4f6f4e2b9c2321b0c2fcd64a) fix: hide masked value - [`7e303eb`](https://github.com/nektos/act/commit/7e303ebebfc02c9f715bc528634eabcf77db0364) Add test to not output secret in add-mask command - [`2d0680a`](https://github.com/nektos/act/commit/2d0680ae13d8224f8203c5349a537c70117c1f90) Merge branch 'master' into hidden-masked-values ### 📊 Changes **2 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/command.go` (+1 -1) 📝 `pkg/runner/command_test.go` (+16 -0) </details> ### 📄 Description The `::add-mask::` command output logs the value to be masked. The current implementation does expose critical information which should be hidden from the output. **Note:** This PR does not implement proper mask handling. It just suppresses the output of the secret in the `add-mask` command. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:39 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1549

No description provided.

Rows
Columns