[PR #665] [MERGED] Add custom docker registry authentication #1546

Closed
opened 2026-03-01 21:51:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/665
Author: @KnisterPeter
Created: 5/5/2021
Status: Merged
Merged: 5/5/2021
Merged by: @cplee

Base: masterHead: docker-registry-auth


📝 Commits (3)

  • b2a789a Add custom docker registry authentication
  • d1833e1 Add test to check if pull authentication is filled in
  • 7f44f83 Update debug message to be more descriptive

📊 Changes

5 files changed (+61 additions, -4 deletions)

View changed files

📝 pkg/container/docker_pull.go (+35 -3)
📝 pkg/container/docker_pull_test.go (+18 -1)
📝 pkg/container/docker_run.go (+4 -0)
📝 pkg/runner/run_context.go (+2 -0)
📝 pkg/runner/step_context.go (+2 -0)

📄 Description

Uses DOCKER_USERNAME and DOCKER_PASSWORD as secrets provided into
the act cli.

Closes #527


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/665 **Author:** [@KnisterPeter](https://github.com/KnisterPeter) **Created:** 5/5/2021 **Status:** ✅ Merged **Merged:** 5/5/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `docker-registry-auth` --- ### 📝 Commits (3) - [`b2a789a`](https://github.com/nektos/act/commit/b2a789ae73739510d55012bcb286aa14888ec3ca) Add custom docker registry authentication - [`d1833e1`](https://github.com/nektos/act/commit/d1833e1a9025dbb35bb556d5c1c35542c2a58a66) Add test to check if pull authentication is filled in - [`7f44f83`](https://github.com/nektos/act/commit/7f44f83b1954fa0fc2e7a6dbbd28495441c73561) Update debug message to be more descriptive ### 📊 Changes **5 files changed** (+61 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_pull.go` (+35 -3) 📝 `pkg/container/docker_pull_test.go` (+18 -1) 📝 `pkg/container/docker_run.go` (+4 -0) 📝 `pkg/runner/run_context.go` (+2 -0) 📝 `pkg/runner/step_context.go` (+2 -0) </details> ### 📄 Description Uses DOCKER_USERNAME and DOCKER_PASSWORD as secrets provided into the act cli. Closes #527 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1546
No description provided.