mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[PR #665] [MERGED] Add custom docker registry authentication #1546
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1546
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/665
Author: @KnisterPeter
Created: 5/5/2021
Status: ✅ Merged
Merged: 5/5/2021
Merged by: @cplee
Base:
master← Head:docker-registry-auth📝 Commits (3)
b2a789aAdd custom docker registry authenticationd1833e1Add test to check if pull authentication is filled in7f44f83Update debug message to be more descriptive📊 Changes
5 files changed (+61 additions, -4 deletions)
View changed files
📝
pkg/container/docker_pull.go(+35 -3)📝
pkg/container/docker_pull_test.go(+18 -1)📝
pkg/container/docker_run.go(+4 -0)📝
pkg/runner/run_context.go(+2 -0)📝
pkg/runner/step_context.go(+2 -0)📄 Description
Uses DOCKER_USERNAME and DOCKER_PASSWORD as secrets provided into
the act cli.
Closes #527
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.