[PR #652] [CLOSED] Fix: Allow known failing actions to gracefully continue #1538

Closed
opened 2026-03-01 21:51:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/652
Author: @JustinGrote
Created: 5/2/2021
Status: Closed

Base: masterHead: JustinGrote/actionsBlacklist


📝 Commits (4)

  • 1e0ab0b Add known failing action blacklist
  • 23e7070 Update to more common log message
  • ecd23ed Make mention of remote
  • b64515f Better wording of skip message

📊 Changes

3 files changed (+49 additions, -22 deletions)

View changed files

📝 pkg/runner/step_context.go (+39 -22)
📝 pkg/runner/step_context_test.go (+1 -0)
pkg/runner/testdata/uses-blacklist/push.yml (+9 -0)

📄 Description

Some actions such as cache, upload-artifact, and download artifact do not work due to lack of an emulated api/server.

A potential path forward exists with #169, but until that is implemented we should silently continue on some actions that would otherwise fail but do not really impact the flow of the action for testing, to allow other actions in the flow to be tested.

This is intended to be temporary until the feature is implemented.

Related: #329, #285

(cherry picked from commit 523ad078bac2610989b1162bdf884675843cbdce)

Output from a run against JustinGrote/Press:
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/652 **Author:** [@JustinGrote](https://github.com/JustinGrote) **Created:** 5/2/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `JustinGrote/actionsBlacklist` --- ### 📝 Commits (4) - [`1e0ab0b`](https://github.com/nektos/act/commit/1e0ab0b606245de75ca98bc1ae6540508c747c22) Add known failing action blacklist - [`23e7070`](https://github.com/nektos/act/commit/23e70709355e5236a92a517ee78372c83676e9b9) Update to more common log message - [`ecd23ed`](https://github.com/nektos/act/commit/ecd23ed243f03cc86d254dfb9c10bb268f0d6985) Make mention of remote - [`b64515f`](https://github.com/nektos/act/commit/b64515f2beba57623d54840afa595d3f0d450b68) Better wording of skip message ### 📊 Changes **3 files changed** (+49 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/step_context.go` (+39 -22) 📝 `pkg/runner/step_context_test.go` (+1 -0) ➕ `pkg/runner/testdata/uses-blacklist/push.yml` (+9 -0) </details> ### 📄 Description Some actions such as cache, upload-artifact, and download artifact do not work due to lack of an emulated api/server. A potential path forward exists with #169, but until that is implemented we should silently continue on some actions that would otherwise fail but do not really impact the flow of the action for testing, to allow other actions in the flow to be tested. This is intended to be temporary until the feature is implemented. Related: #329, #285 (cherry picked from commit 523ad078bac2610989b1162bdf884675843cbdce) Output from a run against JustinGrote/Press: ![image](https://user-images.githubusercontent.com/15258962/116804694-9e912380-aad5-11eb-83c6-781e01bb21ca.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1538
No description provided.