starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 01:15:51 +03:00

[PR #650] [MERGED] Add `super-linter` + fix lint issues #1537

New issue

Closed

opened 2026-03-01 21:51:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/650
Author: @catthehacker
Created: 5/1/2021
Status: ✅ Merged
Merged: 5/3/2021
Merged by: @cplee

Base: master ← Head: golangci-lint

📝 Commits (8)

5203bbd feat: bump golangci-lint, add super-linter, replace outdated linter
36a6f00 fix: lint/fix go files
652d0d9 fix: lint with standardjs
cf420f8 fix: lint/fix with markdownlint, make template more verbose
62964cb feat: add lint stuff to makefile
07e9692 Merge branch 'master' into golangci-lint
943bfd7 fix: UseGitIgnore formatting
b5a871b fix: lint/fix README.md

📊 Changes

24 files changed (+141 additions, -69 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/issue_template.md (+27 -15)
➕ .github/linters/.golangci.yml (+1 -0)
➕ .github/linters/.markdown-lint.yml (+11 -0)
📝 .github/workflows/push.yml (+15 -1)
📝 .golangci.yml (+15 -12)
➕ .vscode/settings.json (+6 -0)
📝 CONTRIBUTING.md (+1 -1)
📝 Makefile (+46 -1)
📝 README.md (+7 -6)
📝 cmd/graph.go (+0 -1)
📝 pkg/common/file.go (+0 -4)
📝 pkg/common/git.go (+0 -1)
📝 pkg/common/git_test.go (+0 -1)
📝 pkg/container/docker_build.go (+0 -1)
📝 pkg/container/docker_pull.go (+0 -2)
📝 pkg/container/docker_run.go (+0 -1)
📝 pkg/model/workflow.go (+6 -10)
📝 pkg/runner/expression_test.go (+0 -2)
📝 pkg/runner/logger.go (+0 -1)
📝 pkg/runner/res/trampoline.js (+5 -5)

...and 4 more files

📄 Description

Add super-linter to lint other languages.
Go linter is disabled because it's currently broken:
https://github.com/github/super-linter/pull/370
Replacing scopelint with exportloopref: "[runner] The linter
'scopelint' is deprecated (since v1.39.0) due to: The repository of the
linter has been deprecated by the owner. Replaced by exportloopref."
Fixed formatting in .golangci.yml
Add addtional linters:
misspell: purely style, detects typos in comments
whitespace: detects leading and trailing whitespace
goimports: it's gofmt + checks unused imports

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/650 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 5/1/2021 **Status:** ✅ Merged **Merged:** 5/3/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `golangci-lint` --- ### 📝 Commits (8) - [`5203bbd`](https://github.com/nektos/act/commit/5203bbd46fefd5343a44d76c93c8bb83f9dce9c2) feat: bump `golangci-lint`, add `super-linter`, replace outdated linter - [`36a6f00`](https://github.com/nektos/act/commit/36a6f0064d418c52f8bba83765aacb330a5d9c0a) fix: lint/fix `go` files - [`652d0d9`](https://github.com/nektos/act/commit/652d0d9c99fcbeb78a17ba57835962787e26d840) fix: lint with `standardjs` - [`cf420f8`](https://github.com/nektos/act/commit/cf420f8b3f12562831976946ad21d046175e1cad) fix: lint/fix with `markdownlint`, make template more verbose - [`62964cb`](https://github.com/nektos/act/commit/62964cbfc7dc8d5633ae2cf9705e713b4c0df337) feat: add lint stuff to makefile - [`07e9692`](https://github.com/nektos/act/commit/07e9692ed47caa2c7f50b1948085f16eb21b53f0) Merge branch 'master' into golangci-lint - [`943bfd7`](https://github.com/nektos/act/commit/943bfd7a29084bee355487240b96591703ce836a) fix: `UseGitIgnore` formatting - [`b5a871b`](https://github.com/nektos/act/commit/b5a871bd463c9cbe98c5c233a0b026bb2b84a6c5) fix: lint/fix `README.md` ### 📊 Changes **24 files changed** (+141 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/issue_template.md` (+27 -15) ➕ `.github/linters/.golangci.yml` (+1 -0) ➕ `.github/linters/.markdown-lint.yml` (+11 -0) 📝 `.github/workflows/push.yml` (+15 -1) 📝 `.golangci.yml` (+15 -12) ➕ `.vscode/settings.json` (+6 -0) 📝 `CONTRIBUTING.md` (+1 -1) 📝 `Makefile` (+46 -1) 📝 `README.md` (+7 -6) 📝 `cmd/graph.go` (+0 -1) 📝 `pkg/common/file.go` (+0 -4) 📝 `pkg/common/git.go` (+0 -1) 📝 `pkg/common/git_test.go` (+0 -1) 📝 `pkg/container/docker_build.go` (+0 -1) 📝 `pkg/container/docker_pull.go` (+0 -2) 📝 `pkg/container/docker_run.go` (+0 -1) 📝 `pkg/model/workflow.go` (+6 -10) 📝 `pkg/runner/expression_test.go` (+0 -2) 📝 `pkg/runner/logger.go` (+0 -1) 📝 `pkg/runner/res/trampoline.js` (+5 -5) _...and 4 more files_ </details> ### 📄 Description Add `super-linter` to lint other languages. Go linter is disabled because it's currently broken: https://github.com/github/super-linter/pull/370 Replacing `scopelint` with `exportloopref`: "[runner] The linter 'scopelint' is deprecated (since v1.39.0) due to: The repository of the linter has been deprecated by the owner. Replaced by exportloopref." Fixed formatting in `.golangci.yml` Add addtional linters: `misspell`: purely style, detects typos in comments `whitespace`: detects leading and trailing whitespace `goimports`: it's gofmt + checks unused imports --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:34 +03:00

[PR #1537] [CLOSED] doc: GITHUB_REF cannot be overriden from event file #1993

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1537

No description provided.

Rows
Columns

[PR #650] [MERGED] Add super-linter + fix lint issues #1537

📋 Pull Request Information

📝 Commits (8)

📊 Changes

📄 Description

[PR #650] [MERGED] Add `super-linter` + fix lint issues #1537