[PR #638] [CLOSED] Draft: Adds services capabilities #1535

New issue

Closed

opened 2026-03-01 21:51:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/638
Author: @Markcial
Created: 4/26/2021
Status: ❌ Closed

Base: master ← Head: ticket-173

📝 Commits (7)

7d86160 Draft: Adds services capabilities
c96e1ea Applies review changes
147192d Merge branch 'master' into ticket-173
ab55ab7 Removes unnecessary log line
13b4b18 Removes old code induced because of the rebase
d550c8c Update pkg/runner/runner_test.go
fb7339e Update pkg/runner/runner_test.go

📊 Changes

5 files changed (+212 additions, -21 deletions)

View changed files

➕ pkg/container/docker_network.go (+36 -0)
📝 pkg/container/docker_run.go (+24 -2)
📝 pkg/runner/run_context.go (+90 -19)
📝 pkg/runner/runner_test.go (+36 -0)
➕ pkg/runner/testdata/services/push.yaml (+26 -0)

📄 Description

Fixes https://github.com/nektos/act/issues/173

Hi, this is a draft MR. Will need some more work

The network is created and removed by name, causing collisions, and it is created only once, I am not sure if that is the right setup, maybe it might be needed to be different on each job.

Containers and services should be included on that network, it's done here but maybe there is a better way. This MR also lacks proper testing, some advice on this would be good.

The configuration on the services are done in a hacky way, they should have properly merged environment settings, and some other configuration values.

I can help on any further changes or if you feel that someone else can't take better care of it feel free to modify it.

Thanks for this project

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/638 **Author:** [@Markcial](https://github.com/Markcial) **Created:** 4/26/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ticket-173` --- ### 📝 Commits (7) - [`7d86160`](https://github.com/nektos/act/commit/7d86160ae17c67cf0878ab9c0b861878c70ab4ff) Draft: Adds services capabilities - [`c96e1ea`](https://github.com/nektos/act/commit/c96e1ea18ce22f49fec5da1b0cee238a7bdf1836) Applies review changes - [`147192d`](https://github.com/nektos/act/commit/147192d87fc22314b9da267091eefb6c1beffbb7) Merge branch 'master' into ticket-173 - [`ab55ab7`](https://github.com/nektos/act/commit/ab55ab79b1c05754ff0e2ef994238d542a54415a) Removes unnecessary log line - [`13b4b18`](https://github.com/nektos/act/commit/13b4b18b47e0df5d848af91a7bce8dbd3b03edbc) Removes old code induced because of the rebase - [`d550c8c`](https://github.com/nektos/act/commit/d550c8ca58e20e9aee3ce3966b2b579b49e557a2) Update pkg/runner/runner_test.go - [`fb7339e`](https://github.com/nektos/act/commit/fb7339e4e71418b09de767268b44d13f4ed30c5e) Update pkg/runner/runner_test.go ### 📊 Changes **5 files changed** (+212 additions, -21 deletions) <details> <summary>View changed files</summary> ➕ `pkg/container/docker_network.go` (+36 -0) 📝 `pkg/container/docker_run.go` (+24 -2) 📝 `pkg/runner/run_context.go` (+90 -19) 📝 `pkg/runner/runner_test.go` (+36 -0) ➕ `pkg/runner/testdata/services/push.yaml` (+26 -0) </details> ### 📄 Description Fixes https://github.com/nektos/act/issues/173 Hi, this is a draft MR. Will need some more work The network is created and removed by name, causing collisions, and it is created only once, I am not sure if that is the right setup, maybe it might be needed to be different on each job. Containers and services should be included on that network, it's done here but maybe there is a better way. This MR also lacks proper testing, some advice on this would be good. The configuration on the services are done in a hacky way, they should have properly merged environment settings, and some other configuration values. I can help on any further changes or if you feel that someone else can't take better care of it feel free to modify it. Thanks for this project --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:35 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:33 +03:00

[PR #1535] [MERGED] build(deps): bump actions/stale from 6 to 7 #1992

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1535

No description provided.

Rows
Columns