[PR #619] [MERGED] fix: rework container architecture flag #1523

New issue

Closed

opened 2026-03-01 21:51:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/619
Author: @catthehacker
Created: 4/15/2021
Status: ✅ Merged
Merged: 5/2/2021
Merged by: @cplee

Base: master ← Head: fix-err

📝 Commits (1)

d3e4134 fix: reworked container architecture

📊 Changes

8 files changed (+74 additions, -104 deletions)

View changed files

📝 README.md (+1 -1)
📝 cmd/root.go (+1 -2)
📝 pkg/container/docker_images.go (+5 -5)
📝 pkg/container/docker_run.go (+1 -1)
📝 pkg/runner/run_context.go (+0 -4)
📝 pkg/runner/runner_test.go (+21 -38)
📝 pkg/runner/step_context.go (+40 -42)
📝 pkg/runner/step_context_test.go (+5 -11)

📄 Description

fix: reworked container architecture

Don't set architecture, let Docker host decide it's own platform,
remove runtime dependency and don't show default in --help
Remove most tests, we need to check only once if it works on
different platform
Rename DeleteImage to RemoveImage to conform to existing
function in docker cli, added options to specify force and
pruneChildren
fixes #621

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/619 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 4/15/2021 **Status:** ✅ Merged **Merged:** 5/2/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `fix-err` --- ### 📝 Commits (1) - [`d3e4134`](https://github.com/nektos/act/commit/d3e413473ffa0a4ce65e74fe53d961974a819c2a) fix: reworked container architecture ### 📊 Changes **8 files changed** (+74 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `cmd/root.go` (+1 -2) 📝 `pkg/container/docker_images.go` (+5 -5) 📝 `pkg/container/docker_run.go` (+1 -1) 📝 `pkg/runner/run_context.go` (+0 -4) 📝 `pkg/runner/runner_test.go` (+21 -38) 📝 `pkg/runner/step_context.go` (+40 -42) 📝 `pkg/runner/step_context_test.go` (+5 -11) </details> ### 📄 Description fix: reworked container architecture - Don't set architecture, let Docker host decide it's own platform, remove runtime dependency and don't show default in `--help` - Remove most tests, we need to check only once if it works on different platform - Rename `DeleteImage` to `RemoveImage` to conform to existing function in `docker` cli, added options to specify `force` and `pruneChildren` fixes #621 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:33 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1523

No description provided.

Rows
Columns