[PR #562] [MERGED] Fix tests on Windows #1497

New issue

Closed

opened 2026-03-01 21:51:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/562
Author: @catthehacker
Created: 3/12/2021
Status: ✅ Merged
Merged: 3/13/2021
Merged by: @cplee

Base: master ← Head: fixes-for-windows

📝 Commits (2)

52c7d0a fix: replace \ with / in git ref to fix git_test.go on windows
f639a20 fix: replace gopkg.in/godo.v2/glob with std library path/filepath

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 pkg/common/git.go (+2 -1)
📝 pkg/runner/expression.go (+3 -4)

📄 Description

Paths on Windows use backslash (\) as directory separator and this breaks TestGitFindRef(). Replacing \ with / in git ref fixes that issue.
Replace external dependency lib with std lib.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/562 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 3/12/2021 **Status:** ✅ Merged **Merged:** 3/13/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `fixes-for-windows` --- ### 📝 Commits (2) - [`52c7d0a`](https://github.com/nektos/act/commit/52c7d0a176fbf78e9fbd8adba9f4cf12a589cbd4) fix: replace `\` with `/` in git ref to fix `git_test.go` on windows - [`f639a20`](https://github.com/nektos/act/commit/f639a20cac38d32ecafe24a32c12d3f7b2bdcdd9) fix: replace `gopkg.in/godo.v2/glob` with std library `path/filepath` ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkg/common/git.go` (+2 -1) 📝 `pkg/runner/expression.go` (+3 -4) </details> ### 📄 Description - Paths on Windows use backslash (`\`) as directory separator and this breaks `TestGitFindRef()`. Replacing `\` with `/` in git ref fixes that issue. - Replace external dependency lib with std lib. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:25 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:28 +03:00

[PR #1497] [MERGED] feat: Support "result" on "needs" context. #1969

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1497

No description provided.

Rows
Columns