[PR #557] [CLOSED] Set step results to map more closely to reality #1494

New issue

Closed

opened 2026-03-01 21:51:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/557
Author: @pezholio
Created: 3/8/2021
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

315f1cf Set step results to map more closely to reality

📊 Changes

4 files changed (+11 additions, -11 deletions)

View changed files

📝 pkg/runner/expression_test.go (+3 -3)
📝 pkg/runner/run_context.go (+6 -6)
📝 pkg/runner/run_context_test.go (+1 -1)
📝 pkg/runner/step_context.go (+1 -1)

📄 Description

This partially addresses #465 by setting the outcome to "success" or "failure" depending whether a step passes or fails (see https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#steps-context)

I don't know enough Go to address the conclusion part of the output, but this is an improvement on what we have before.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/557 **Author:** [@pezholio](https://github.com/pezholio) **Created:** 3/8/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`315f1cf`](https://github.com/nektos/act/commit/315f1cf60bf88aa15a44cb497c1272e6f0ff45ce) Set step results to map more closely to reality ### 📊 Changes **4 files changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/expression_test.go` (+3 -3) 📝 `pkg/runner/run_context.go` (+6 -6) 📝 `pkg/runner/run_context_test.go` (+1 -1) 📝 `pkg/runner/step_context.go` (+1 -1) </details> ### 📄 Description This partially addresses #465 by setting the outcome to "success" or "failure" depending whether a step passes or fails (see https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#steps-context) I don't know enough Go to address the conclusion part of the output, but this is an improvement on what we have before. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:25 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:27 +03:00

[PR #1494] [MERGED] fix: use correct path to toolcache #1967

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1494

No description provided.

Rows
Columns