[PR #502] [MERGED] Shouldn't rewrite dot in a string to index syntax #1473

New issue

Closed

opened 2026-03-01 21:51:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/502
Author: @lufia
Created: 1/23/2021
Status: ✅ Merged
Merged: 2/8/2021
Merged by: @cplee

Base: master ← Head: fix-expr-string

📝 Commits (2)

8f1886c Shouldn't rewrite dot in a string to index syntax
119e46f Merge branch 'master' into fix-expr-string

📊 Changes

2 files changed (+77 additions, -10 deletions)

View changed files

📝 pkg/runner/expression.go (+75 -10)
📝 pkg/runner/expression_test.go (+2 -0)

📄 Description

Closes #496

Notes:

strings.Builder.WriteRune and others describes:

It returns the length of r and a nil error.

So I added //nolint comment to each statement.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/502 **Author:** [@lufia](https://github.com/lufia) **Created:** 1/23/2021 **Status:** ✅ Merged **Merged:** 2/8/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `fix-expr-string` --- ### 📝 Commits (2) - [`8f1886c`](https://github.com/nektos/act/commit/8f1886ca6d4516d3bcacec46602659e7940c4e7e) Shouldn't rewrite dot in a string to index syntax - [`119e46f`](https://github.com/nektos/act/commit/119e46f27842808207f61370e48b15455620b5d1) Merge branch 'master' into fix-expr-string ### 📊 Changes **2 files changed** (+77 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/expression.go` (+75 -10) 📝 `pkg/runner/expression_test.go` (+2 -0) </details> ### 📄 Description Closes #496 Notes: *strings.Builder.WriteRune* and others describes: > It returns the length of r and a nil error. So I added `//nolint` comment to each statement. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:20 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:47 +03:00

[PR #1646] [MERGED] fix: github.job property is empty, GITHUB_JOB should be job id #2048

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1473

No description provided.

Rows
Columns