[PR #500] [MERGED] Throw an error if the steps has a invalid uses directive #1471

Closed
opened 2026-03-01 21:51:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/500
Author: @lufia
Created: 1/22/2021
Status: Merged
Merged: 1/23/2021
Merged by: @cplee

Base: masterHead: fix-panics


📝 Commits (2)

  • cc9596a Throw an error if the steps has a invalid uses directive
  • bee52cf Refactor TestStepContextExecutor

📊 Changes

6 files changed (+73 additions, -17 deletions)

View changed files

📝 pkg/runner/step_context.go (+20 -17)
pkg/runner/step_context_test.go (+25 -0)
pkg/runner/testdata/uses-github-empty/push.yml (+7 -0)
pkg/runner/testdata/uses-github-noref/push.yml (+7 -0)
pkg/runner/testdata/uses-github-path/push.yml (+7 -0)
pkg/runner/testdata/uses-github-root/push.yml (+7 -0)

📄 Description

This closes #402, closes #487


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/500 **Author:** [@lufia](https://github.com/lufia) **Created:** 1/22/2021 **Status:** ✅ Merged **Merged:** 1/23/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `fix-panics` --- ### 📝 Commits (2) - [`cc9596a`](https://github.com/nektos/act/commit/cc9596aaa040d53888df8227b430c9c7f911f7c1) Throw an error if the steps has a invalid uses directive - [`bee52cf`](https://github.com/nektos/act/commit/bee52cf1247bc4728f68fd98934c7d2d7ca8297e) Refactor TestStepContextExecutor ### 📊 Changes **6 files changed** (+73 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/step_context.go` (+20 -17) ➕ `pkg/runner/step_context_test.go` (+25 -0) ➕ `pkg/runner/testdata/uses-github-empty/push.yml` (+7 -0) ➕ `pkg/runner/testdata/uses-github-noref/push.yml` (+7 -0) ➕ `pkg/runner/testdata/uses-github-path/push.yml` (+7 -0) ➕ `pkg/runner/testdata/uses-github-root/push.yml` (+7 -0) </details> ### 📄 Description This closes #402, closes #487 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1471
No description provided.