[PR #423] [MERGED] Change setupEnv to return an ExpressionEvaluator #1443

New issue

Closed

opened 2026-03-01 21:51:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/423
Author: @winksaville
Created: 11/16/2020
Status: ✅ Merged
Merged: 1/13/2021
Merged by: @cplee

Base: master ← Head: fix-issue-416

📝 Commits (1)

573333b Fix issue 416

📊 Changes

2 files changed (+42 additions, -26 deletions)

View changed files

📝 pkg/runner/run_context.go (+4 -8)
📝 pkg/runner/step_context.go (+38 -18)

📄 Description

This is a solution to issue #416 where environment variables created or
changed in the previous step are not usable in the next step because
the rc.ExprEval is from the beginning of the previous step.

This change refactors setupEnv so that before interpolating the environment
variables a NewExpressionEvaluator is created.

Fixes: 416

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/423 **Author:** [@winksaville](https://github.com/winksaville) **Created:** 11/16/2020 **Status:** ✅ Merged **Merged:** 1/13/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `fix-issue-416` --- ### 📝 Commits (1) - [`573333b`](https://github.com/nektos/act/commit/573333be77e1bdf8eaf681126615765408844857) Fix issue 416 ### 📊 Changes **2 files changed** (+42 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+4 -8) 📝 `pkg/runner/step_context.go` (+38 -18) </details> ### 📄 Description This is a solution to issue #416 where environment variables created or changed in the previous step are not usable in the next step because the rc.ExprEval is from the beginning of the previous step. This change refactors setupEnv so that before interpolating the environment variables a NewExpressionEvaluator is created. Fixes: 416 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:12 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1443

No description provided.

Rows
Columns