[PR #381] [MERGED] Remove confusing message about symlinks #1429

New issue

Closed

opened 2026-03-01 21:51:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/381
Author: @lyleunderwood
Created: 10/3/2020
Status: ✅ Merged
Merged: 10/6/2020
Merged by: @cplee

Base: master ← Head: symlinks

📝 Commits (1)

4c2cabb Remove confusing message about symlinks

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 pkg/container/docker_run.go (+1 -1)

📄 Description

Fixes #209

It turns out that act does copy symlinks. I've setup a test case here:

github.com/lyleunderwood/github-actions-demo@d904f63b1b

Below is the output. Notice the message, "Unable to copy link test --> README.md" followed shortly by the description and usage of the corresponding symlink that exists within the workspace.

lyle@lyle-t410:~/dev/github-actions-demo$ act
[CI/test] 🚀  Start image=node:12.6-buster-slim
[CI/test]   🐳  docker run image=node:12.6-buster-slim entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[]
[CI/test]   🐳  docker cp src=/home/lyle/dev/github-actions-demo/. dst=/github/workspace
[CI/test] Unable to copy link test --> README.md
[CI/test] ⭐  Run actions/checkout@v2
[CI/test]   ✅  Success - actions/checkout@v2
[CI/test] ⭐  Run ls -l ./test
| lrwxrwxrwx 1 node node 9 Oct  2 23:51 ./test -> README.md
[CI/test]   ✅  Success - ls -l ./test
[CI/test] ⭐  Run head ./test
| # Overview
| Simple Node.js application to demonstrate the use of GitHub Actions
| 
| # Look Ma, no Makefile!
| All the tasks necessary for testing, building and deploying this code is already defined in `.github/workflows/` so why would you want to also create a `Makefile` for local development?  Now you can use [act](https://github.com/nektos/act) to run the actions locally!
| 
| Try these:
| 
| * `act -j lint` - run the linter
| * `act -j test` - run the tests
[CI/test]   ✅  Success - head ./test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/381 **Author:** [@lyleunderwood](https://github.com/lyleunderwood) **Created:** 10/3/2020 **Status:** ✅ Merged **Merged:** 10/6/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `symlinks` --- ### 📝 Commits (1) - [`4c2cabb`](https://github.com/nektos/act/commit/4c2cabb9501c60a5dea0933dca2770ae8a752314) Remove confusing message about symlinks ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+1 -1) </details> ### 📄 Description Fixes #209 It turns out that `act` _does_ copy symlinks. I've setup a test case here: https://github.com/lyleunderwood/github-actions-demo/commit/d904f63b1b4bdc2d96ff0d6953581a39ff83f4db Below is the output. Notice the message, "Unable to copy link test --> README.md" followed shortly by the description and usage of the corresponding symlink that exists within the workspace. ``` lyle@lyle-t410:~/dev/github-actions-demo$ act [CI/test] 🚀 Start image=node:12.6-buster-slim [CI/test] 🐳 docker run image=node:12.6-buster-slim entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[] [CI/test] 🐳 docker cp src=/home/lyle/dev/github-actions-demo/. dst=/github/workspace [CI/test] Unable to copy link test --> README.md [CI/test] ⭐ Run actions/checkout@v2 [CI/test] ✅ Success - actions/checkout@v2 [CI/test] ⭐ Run ls -l ./test | lrwxrwxrwx 1 node node 9 Oct 2 23:51 ./test -> README.md [CI/test] ✅ Success - ls -l ./test [CI/test] ⭐ Run head ./test | # Overview | Simple Node.js application to demonstrate the use of GitHub Actions | | # Look Ma, no Makefile! | All the tasks necessary for testing, building and deploying this code is already defined in `.github/workflows/` so why would you want to also create a `Makefile` for local development? Now you can use [act](https://github.com/nektos/act) to run the actions locally! | | Try these: | | * `act -j lint` - run the linter | * `act -j test` - run the tests [CI/test] ✅ Success - head ./test ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:08 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:21 +03:00

[PR #1429] [CLOSED] feat: add support for writing to GITHUB_OUTPUT #1945

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1429

No description provided.

Rows
Columns