[PR #371] [MERGED] Fix path for local node12 actions #1425

New issue

Closed

opened 2026-03-01 21:51:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/371
Author: @jromero
Created: 9/25/2020
Status: ✅ Merged
Merged: 9/29/2020
Merged by: @cplee

Base: master ← Head: fix/185-local-js

📝 Commits (2)

d88bd46 Fix path for local node12 actions
4497a82 Merge remote-tracking branch 'upstream/master' into fix/185-local-js

📊 Changes

15 files changed (+6206 additions, -10 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 Makefile (+5 -1)
📝 pkg/runner/expression_test.go (+1 -1)
📝 pkg/runner/run_context.go (+2 -2)
📝 pkg/runner/runner_test.go (+2 -0)
📝 pkg/runner/step_context.go (+6 -4)
➕ pkg/runner/testdata/actions/node12/.gitignore (+1 -0)
➕ pkg/runner/testdata/actions/node12/README.md (+3 -0)
➕ pkg/runner/testdata/actions/node12/action.yml (+13 -0)
➕ pkg/runner/testdata/actions/node12/dist/index.js (+5950 -0)
➕ pkg/runner/testdata/actions/node12/index.js (+15 -0)
➕ pkg/runner/testdata/actions/node12/package-lock.json (+177 -0)
➕ pkg/runner/testdata/actions/node12/package.json (+20 -0)
📝 pkg/runner/testdata/basic/push.yml (+0 -1)
➕ pkg/runner/testdata/local-action-js/push.yml (+10 -0)

📄 Description

This changes makes it so that the proper path is used when executing a local javascript (node12) action.

Additional minor changes:

Updated Makefile
- Updated make test to be functional by running expected go test task based on README.md
- Added make format to format based on CONTRIBUTING.md
- Made GITHUB_TOKEN be set only once instead of re-executing cat per target.
Update expression_tests to retain previous behaviour (when no file matched) now that a package-lock.json file exists in testdata.

Fixes #185

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/371 **Author:** [@jromero](https://github.com/jromero) **Created:** 9/25/2020 **Status:** ✅ Merged **Merged:** 9/29/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `fix/185-local-js` --- ### 📝 Commits (2) - [`d88bd46`](https://github.com/nektos/act/commit/d88bd46fd42cff8c4f5e9c26094d2a269a3b1dee) Fix path for local node12 actions - [`4497a82`](https://github.com/nektos/act/commit/4497a8232e9df1836e16fa699d91d58ce273d25f) Merge remote-tracking branch 'upstream/master' into fix/185-local-js ### 📊 Changes **15 files changed** (+6206 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `Makefile` (+5 -1) 📝 `pkg/runner/expression_test.go` (+1 -1) 📝 `pkg/runner/run_context.go` (+2 -2) 📝 `pkg/runner/runner_test.go` (+2 -0) 📝 `pkg/runner/step_context.go` (+6 -4) ➕ `pkg/runner/testdata/actions/node12/.gitignore` (+1 -0) ➕ `pkg/runner/testdata/actions/node12/README.md` (+3 -0) ➕ `pkg/runner/testdata/actions/node12/action.yml` (+13 -0) ➕ `pkg/runner/testdata/actions/node12/dist/index.js` (+5950 -0) ➕ `pkg/runner/testdata/actions/node12/index.js` (+15 -0) ➕ `pkg/runner/testdata/actions/node12/package-lock.json` (+177 -0) ➕ `pkg/runner/testdata/actions/node12/package.json` (+20 -0) 📝 `pkg/runner/testdata/basic/push.yml` (+0 -1) ➕ `pkg/runner/testdata/local-action-js/push.yml` (+10 -0) </details> ### 📄 Description This changes makes it so that the proper path is used when executing a local javascript (`node12`) action. Additional minor changes: - Updated Makefile - Updated `make test` to be functional by running expected `go test` task based on [README.md](https://github.com/nektos/act#building-from-source) - Added `make format` to format based on [CONTRIBUTING.md](https://github.com/nektos/act/blob/master/CONTRIBUTING.md#-styleguide) - Made `GITHUB_TOKEN` be set only once instead of re-executing `cat` per target. - Update `expression_tests` to retain previous behaviour (when no file matched) now that a `package-lock.json` file exists in `testdata`. Fixes #185 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:07 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:20 +03:00

[PR #1425] [MERGED] Remove dead code #1941

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1425

No description provided.

Rows
Columns