[PR #349] [MERGED] Special case handling of empty workflow files for user experience #1419

Closed
opened 2026-03-01 21:51:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/349
Author: @cdb
Created: 8/31/2020
Status: Merged
Merged: 8/31/2020
Merged by: @cplee

Base: masterHead: handle-empty-file


📝 Commits (2)

  • 4122ce6 Special case handling of empty workflow files for user experience
  • 37af701 Merge branch 'master' into handle-empty-file

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 pkg/model/planner.go (+5 -0)

📄 Description

Fixes https://github.com/nektos/act/issues/340 - this just makes the error a bit more understandable if a user has an empty workflow file.

Alternatively, I could simply wrap the error in all cases so that it's decorated with the file.Name(), that might be more broadly useful?

(trying to learn the codebase through some small PRs, thanks in advance!!)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/349 **Author:** [@cdb](https://github.com/cdb) **Created:** 8/31/2020 **Status:** ✅ Merged **Merged:** 8/31/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `handle-empty-file` --- ### 📝 Commits (2) - [`4122ce6`](https://github.com/nektos/act/commit/4122ce64f8083909f51688ac9b7657a90f07234b) Special case handling of empty workflow files for user experience - [`37af701`](https://github.com/nektos/act/commit/37af701633faa599862742cdb4bd02e16092ab4b) Merge branch 'master' into handle-empty-file ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/planner.go` (+5 -0) </details> ### 📄 Description Fixes https://github.com/nektos/act/issues/340 - this just makes the error a bit more understandable if a user has an empty workflow file. Alternatively, I could simply wrap the error in _all_ cases so that it's decorated with the `file.Name()`, that might be more broadly useful? (trying to learn the codebase through some small PRs, thanks in advance!!) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1419
No description provided.